unclear name/description for download sources

[maxandersen]

the name and description for "download sources" is a bit confusing.

1. does turning this setting on enable or disable download of sources?
2. what does "Eclipse:" refer to ? no other setting has this.

I would assume something like the following is more clear (based on how it seem to behave on my machine at least):

"Java > Download Sources Always Download of Maven sources will always happen not just on demand which is the default."

[fbricon]

checked == enabled

This setting is used for Eclipse projects specifically, as in no Maven nor Gradle, pure .project, .classpath eclipse projects. It basically brings the same download capabilities to Eclipse projects that Maven or Gradle have. Not turned on by default because it uses hard coded paths for source files in .classpath

[rgrunber]

Looking under the VS Code settings I see :

"Enable ..." "Enable/disable ..." "Enable(s) or disable(s) ..." "Control(s) ..."

In some cases, skipping the above phrases and just saying what happens could also be very clear. I think its a matter of getting some upstream guidance on what terminology is preferred.

[maxandersen]

Imo Just remove the prefix. They are either redundant (Enables) or ambigious (Enables/disables)