vscode-didact icon indicating copy to clipboard operation
vscode-didact copied to clipboard

Success message printed also when command fails

Open nicolaferraro opened this issue 4 years ago • 2 comments

I'm using this:

[Check if you're connected to an OpenShift cluster](didact://?commandId=vscode.didact.requirementCheck&text=cluster-requirements-status$$oc%20get%20project$$NAME&completion=OpenShift%20is%20connected. "Tests to see if `kamel version` returns a result"){.didact}

*Status: unknown*{#cluster-requirements-status}
``

When I'm not connected to an OpenShift cluster, the command fails, the status is correctly set to "Unavailable", but the popup on the bottom right corner says "OpenShift is connected.", which is wrong.

How do we deal with this? Should we put a generic message, like "OpenShift connection checked" instead of a success message? Can we override the failure message?

nicolaferraro avatar Mar 25 '20 14:03 nicolaferraro

Yes, providing a more generic message is probably the way to go for now. Completion messages are popped up if it completes -- which it does by updating the status message.

We should probably look at popping an error message instead, but it's not really an error, just a status so I didn't want to assume that it was in error...

bfitzpat avatar Mar 25 '20 15:03 bfitzpat

jira issue https://issues.redhat.com/browse/FUSETOOLS2-654

apupier avatar Sep 15 '20 08:09 apupier