Disable notifications after commands

[gorkem]

Didact sends a notification after each command executed on the tutorial like the following. These notifications should be optional and disabled by default unless the command has the completion defined explicitly.

Didact just executed vscode.didact.sendNamedTerminalAString with arguments oc-terminal,oc whoami

[bfitzpat]

These are the notifications displayed in vscode as popups in the lower right corner? Or the notifications we show in the Didact activity output channel?

[gorkem]

These are the lower right corner toast notifications.

[bfitzpat]

You think there should be no default notification except in the case where completion text has been specified? I wanted to avoid the phantom click syndrome as much as possible where the user had no idea that changes had been made at all.

In fact, Hiram brought up the issue I documented in https://github.com/redhat-developer/vscode-didact/issues/31 -- so I'm wondering if we need more feedback to the user, not less??

I do agree that maybe there should be an option to turn them off. A preference probably.

[gorkem]

I am not sure how a toast notification helps with #31. It actually draws attention away from terminal. Can we enhance the stylesheet so that we get more feedback on clicks and perhaps links are more button like?

[bfitzpat]

Would love to enhance the stylesheet. Definitely open to suggestions on how to pull that off.

[paoloantinori]

I think we should add double support:

• a global configuration flag that overrides everything, defaulting to off
• an optional param for each command

and apply a logical OR between the two values to decide when to display

[bfitzpat]

This PR -- https://github.com/redhat-developer/vscode-didact/pull/48

Right now with this PR, the behavior is:

• Don't show all generic completion toast messages. These were generated for every command clicked in the Didact file, regardless of whether a completion message was specified. You can turn this off and see them again if you so desire.
• If a link has a completion message specified, it will get shown.

I don't think we want to turn off ALL toast completion messages, but I agree that the signal to noise is more noise than we need with all the default messages popping up and polluting the list.

[bfitzpat]

Will show up in the next release (already committed on master)

[bfitzpat]

@gorkem I'm interested in the sorts of stylesheet animations we could provide for Didact links to make them more visible to the user. I was able pretty quickly to add some CSS to make these buttons get the little animation edge.

Do you have any suggestions on animated links that you have seen elsewhere that might do what we're needing?

[bfitzpat]

Maybe something like this: https://codepen.io/Antariano/pen/vNeJrN

[bfitzpat]

Here are a couple of examples of how it might work in light and dark themes

[pwright]

supporting link styles while switching VS Code themes is challenging, however I think it's worth doing... These styles help users distinguish between url links and didact links, so +1