s2i-dotnetcore icon indicating copy to clipboard operation
s2i-dotnetcore copied to clipboard

Published 20 hours ago • verified publisher icon redhat-developer

Should the build script set `FORCE` to `true` by default?

Open omajid opened this issue 2 years ago • 1 comments

I wasted quite a bit of time today because my changes to the assemble scripts were not showing up. It turns out we only build things once, and never again if the containers exist.

We can fix that by setting FORCE to true:

https://github.com/redhat-developer/s2i-dotnetcore/blob/f45a2e59a023dc983f513410582893dbafd5d727/build.sh#L41

That would mean that a simple execution of ./build.sh would do extra work, but it would ensure that stale assets are never used. Users can still optimize their workflow by setting FORCE to false.

omajid avatar Mar 25 '22 17:03 omajid

I don't have a particular preference either way.

aslicerh avatar Mar 29 '22 12:03 aslicerh

I don't ever set this flag, I delete the images if I want to rebuild them.

tmds avatar Feb 15 '23 14:02 tmds

Closing old issue.

tmds avatar Aug 25 '23 08:08 tmds