odo icon indicating copy to clipboard operation
odo copied to clipboard

Variable substitution does not work in pod-overrides and container-overrides

Open valaparthvi opened this issue 2 years ago • 6 comments

components:
  - container:
      image: quay.io/tkral/devbox-demo-devbox
    attributes:
      pod-overrides:
        spec:
          serviceAccountName: "{{RESOURCE_NAME}}"
variables:
  RESOURCE_NAME: my-go-app
$ odo dev
 /  \__     Developing using the "restapi" Devfile
 \__/  \    Namespace: restapi-mongodb
 /  \__/    odo version: v3.9.0
 \__/

↪ Running on the cluster in Dev mode
 •  Waiting for Kubernetes resources  ...
Cleaning resources, please wait
 ✗  unable to create or update component: unable to update Deployment restapi-app: Deployment.apps "restapi-app" is invalid: spec.template.spec.serviceAccountName: Invalid value: "{{RESOURCE_NAME}}": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

"{{RESOURCE NAME}}" should be replaced by "my-go-app", instead an error is returned.

This probably needs to be fixed on the devfile/library side.

/kind bug /area devfile-spec

valaparthvi avatar Apr 22 '23 09:04 valaparthvi

A friendly reminder that this issue had no activity for 90 days. Stale issues will be closed after an additional 30 days of inactivity.

github-actions[bot] avatar Jul 26 '23 00:07 github-actions[bot]

This issue was closed because it has been inactive for 30 days since being marked as stale.

github-actions[bot] avatar Aug 26 '23 00:08 github-actions[bot]

Still relevant as an issue.

/reopen /remove-lifecycle rotten /remove-lifecycle stale

rm3l avatar Aug 28 '23 11:08 rm3l

@rm3l: Reopened this issue.

In response to this:

Still relevant as an issue.

/reopen /remove-lifecycle rotten /remove-lifecycle stale

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Aug 28 '23 11:08 openshift-ci[bot]

A friendly reminder that this issue had no activity for 90 days. Stale issues will be closed after an additional 30 days of inactivity.

github-actions[bot] avatar Nov 27 '23 00:11 github-actions[bot]

/remove-lifecycle stale /lifecycle frozen /remove-status needs-triage

rm3l avatar Nov 27 '23 08:11 rm3l