odo icon indicating copy to clipboard operation
odo copied to clipboard

odo list: add odo version used to create a component to the output

Open valaparthvi opened this issue 3 years ago • 11 comments

What type of PR is this: /kind feature

What does this PR do / why we need it: This PR adds the component manager version to odo list output.

Which issue(s) this PR fixes:

Fixes #5962

PR acceptance criteria:

  • [x] Unit test

  • [x] Integration test

  • [ ] Documentation

How to test changes / Special notes to the reviewer:

mkdir /tmp/101; cd /tmp/101
odo init --devfile nodejs --name my-node-app --starter nodejs-starter
odo dev
odo list
$ odo list
 ✓  Listing components from namespace 'myproject' [3s]                                                                                            
 NAME               PROJECT TYPE  RUNNING IN  MANAGED                                                                                             
 my-node-app        nodejs        Dev         odo (v3.0.0-beta3)                                                                                  
 code-with-quarkus  Unknown       None        odc
odo list -o json
$ odo list -o json                                                                                                    
{                                                                                                                                                 
        "components": [                                                                                                                           
                {                                                                                                                                 
                        "name": "my-node-app",                                                                                                    
                        "managedBy": "odo",                                                                                                       
                        "managedByVersion": "v3.0.0-beta3",                                                                                       
                        "runningIn": [                                                                                                            
                                "Dev"                                                                                                             
                        ],                                                                                                                        
                        "projectType": "nodejs"                                                                                                   
                },                                                                                                                                
                {                                                                                                                                 
                        "name": "code-with-quarkus",                                                                                              
                        "managedBy": "odc",                                                                                                       
                        "managedByVersion": "",                                                                                                   
                        "runningIn": null,                                                                                                        
                        "projectType": "Unknown"                                                                                                  
                }                                                                                                                                 
        ]                                                                                                                                         
}

valaparthvi avatar Aug 17 '22 07:08 valaparthvi

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
Latest commit 496f8ce9630427e944493f15f0dfefae6bd0d8b0
Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62fcd9338e3d1500086b2ac8

netlify[bot] avatar Aug 17 '22 07:08 netlify[bot]

Unit Tests on commit b22b1256cd40061b3f8f87581b8bce935fbb5326 finished successfully. View logs: TXT HTML

odo-robot[bot] avatar Aug 17 '22 07:08 odo-robot[bot]

Validate Tests on commit b22b1256cd40061b3f8f87581b8bce935fbb5326 finished successfully. View logs: TXT HTML

odo-robot[bot] avatar Aug 17 '22 07:08 odo-robot[bot]

OpenShift Tests on commit b22b1256cd40061b3f8f87581b8bce935fbb5326 finished successfully. View logs: TXT HTML

odo-robot[bot] avatar Aug 17 '22 07:08 odo-robot[bot]

Kubernetes Tests on commit b22b1256cd40061b3f8f87581b8bce935fbb5326 finished successfully. View logs: TXT HTML

odo-robot[bot] avatar Aug 17 '22 07:08 odo-robot[bot]

Windows Tests (OCP) on commit b22b1256cd40061b3f8f87581b8bce935fbb5326 finished with errors. View logs: TXT HTML

odo-robot[bot] avatar Aug 17 '22 10:08 odo-robot[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

sonarqubecloud[bot] avatar Aug 17 '22 12:08 sonarqubecloud[bot]

/approve Works well and code looks good! Thanks @valaparthvi

cdrage avatar Aug 17 '22 14:08 cdrage

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 17 '22 14:08 openshift-ci[bot]

/override windows-integration-test/Windows-test

feloy avatar Aug 17 '22 17:08 feloy

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Aug 17 '22 17:08 openshift-ci[bot]