odo icon indicating copy to clipboard operation
odo copied to clipboard

Cleanup `ComponentSettings` struct and `LocalConfigProvider` interface

Open rm3l opened this issue 3 years ago • 0 comments

/kind task /area refactoring

This is a follow-up to a discussion in #5852

Would it be possible to clean up the code by removing both Name and AppName fields from the ComponentSettings struct? I guess this will require cleaning up further things, like removing the GetApplication and GetName methods from the LocalConfigProvider interface as well..

Maybe I've missed something, but I think that this way, we would be sure no one can use that information (I've tested this PR against an existing project that already has component and app names in its env.yaml files, but then from the code perspective, there is currently nothing in this PR preventing from loading and using such information).

Originally posted by @rm3l in https://github.com/redhat-developer/odo/pull/5852#pullrequestreview-1052758059

rm3l avatar Jul 28 '22 07:07 rm3l