odo icon indicating copy to clipboard operation
odo copied to clipboard

Support `openshift` Devfile components (the same way as `kubernetes` components)

Open rm3l opened this issue 3 years ago • 0 comments

/kind feature

Stumbled upon this while working on #5451

Which functionality do you think we should add?

openshift components should have been deprecated and removed from the Devfile specification, but this is currently not the case. So odo should support them.

Why is this needed?

At this time, running odo deploy with an openshift component does not output any error/warning messages, and does not deploy the component either, which seems quite confusing. For example, running odo deploy with the following devfile.yaml succeeds with the following message: Your Devfile has been successfully deployed, but nothing was actually deployed.

After a discussion with @kadel:

So there is a history behind openshfit component in devfile. It was there in devfile v1, and it got carried over to devfile v2, but the decision was made that it doesn't make much sense to have both openshift and kubernetes components when they are doing the same thing and that having just kubernetes component is ok. But it looks like it was never deprecated from the spec. That is why it was never implemented. But because it looks like it was never deprecated, and removing it would mean breaking change in spec, we will have to support it now.

rm3l avatar Apr 29 '22 09:04 rm3l