odo icon indicating copy to clipboard operation
odo copied to clipboard

Support projects with dockerfile

Open gorkem opened this issue 6 years ago • 6 comments

[kind/Feature]

Which functionality do you think we should add?

Allow projects that has a dockerfile to be taken into the inner-loop mode. User should be able to run a command such as odo create --image=<path/to/my/dockerfile. This is a different mode than our current s2i based mode. As a consequence we need a way to capture the commands to modify the contents of the image.

Why is this needed?

There are many container based applications that has a dockerfile and do not use s2i as their build. This will allow them to use odo to do their inner-loop without making major changes to do s2i based builds.

gorkem avatar Nov 04 '19 14:11 gorkem

when using this feature, as we cannot know the variables like DEPLOYMENT_DIR etc that are present when s2i builder images are used and also we dont control the startup commands - Features like smarter push and debug wouldn't work.

Instead of smarter push either odo push --config could happen when only the config is changed or a rebuild could happen.

correct me if I am wrong @kadel

girishramnani avatar Nov 04 '19 14:11 girishramnani

is this something we are still interested in @kadel @gorkem ?

girishramnani avatar Dec 18 '19 20:12 girishramnani

is this something we are still interested in @kadel @gorkem ?

It might take a different form, but yes. This is something that we are still interested in

kadel avatar Dec 20 '19 14:12 kadel

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Mar 19 '20 17:03 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Apr 18 '20 19:04 openshift-bot

/remove-lifecycle rotten /lifecycle frozen

kadel avatar Apr 20 '20 08:04 kadel