fix: corrected deprecated usage of ModuleLister.moduleAdded (#732)

[adietish]

(partially) fixes #732

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[adietish]

ModuleListener#modulesAdded was added in IC-2022.3 and this PR thus requires us to bump the minimal version from (currently) IC-2022.1 to IC-2022.3

[sbouchet]

ModuleListener#modulesAdded was added in IC-2022.3 and this PR thus requires us to bump the minimal version from (currently) IC-2022.1 to IC-2022.3

I think we'll bump minimal version when 2024.1 will be out .

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[adietish]

ModuleListener#modulesAdded was added in IC-2022.3 and this PR thus requires us to bump the minimal version from (currently) IC-2022.1 to IC-2022.3

I think we'll bump minimal version when 2024.1 will be out .

I checked it and found out that I was wrong: the API required for this change only exists in IC-2023.1 (not present in IC-2022.3).

[sbouchet]

@adietish this is still a warning on current 1.9.0 release. can you update this fix with latest main branch ?

[adietish]

@sbouchet: we're currently still at IC-2022.3 as minimum supported version. For this fix to be applicable we need IC-2023.1 (see https://github.com/redhat-developer/intellij-openshift-connector/pull/740#issuecomment-2062000265)

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[mohitsuman]

@adietish what is the update on this PR ?

[adietish]

@mohitsuman, @sbouchet: we're still at 2022.3: Do we want to bump so that we can include this PR?

[mohitsuman]

@adietish Are there any challenges in bumping ?

[mohitsuman]

And should we move this PR our of Draft state ?

[sbouchet]

@mohitsuman @adietish : I propose to merge this PR after #889, bumping minimal version to 2023.1 .

[mohitsuman]

@sbouchet PR #889 can be merged when ?

[sbouchet]

@sbouchet PR #889 can be merged when ?

almost, there is still Integration UI test failures that @martinszuc is looking at

[adietish]

@sbouchet rebased it.

[sonarqubecloud[bot]]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sbouchet]

as expected, minimal version check (22.3) failed. let's wait for minimal version bump before merging this one.

[adietish]

@sbouchet: intellij-kubernetes is now requiring IC-2023.1. We could thus now bump this and merge this?

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sbouchet]

@sbouchet: intellij-kubernetes is now requiring IC-2023.1. We could thus now bump this and merge this?

yes, now is a good time to do so.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbouchet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [sbouchet]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[adietish]

/override ci/prow/e2e-openshift "Integration UI Tests with Local Kind Cluster Context Report"

[openshift-ci[bot]]

@adietish: Overrode contexts on behalf of adietish: Integration UI Tests with Local Kind Cluster Context Report, ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift "Integration UI Tests with Local Kind Cluster Context Report"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[adietish]

/override "Integration UI Tests with Local Kind Cluster Context Report"

[openshift-ci[bot]]

@adietish: Overrode contexts on behalf of adietish: Integration UI Tests with Local Kind Cluster Context Report

In response to this:

/override "Integration UI Tests with Local Kind Cluster Context Report"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.