devspaces icon indicating copy to clipboard operation
devspaces copied to clipboard

chore: remove old staging/devspaces/build-requirements/devspaces-*-pluginregistry folders from spmm-util server once they're outdated

Open nickboldt opened this issue 1 year ago • 3 comments

What does this PR do?

chore: remove old staging/devspaces/build-requirements/devspaces-*-pluginregistry folders from spmm-util server once they're outdated

Change-Id: I09305e51700b04197ff4a636e36616320c6d8f70 Signed-off-by: RHDH Build (rhdh-bot) [email protected]

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit message above for issue number)

How to test this PR?

run the script using the new flag --delete-old-versions

check if https://download.devel.redhat.com/rcm-guest/staging/devspaces/build-requirements/devspaces-3.7-pluginregistry/ and https://download.devel.redhat.com/rcm-guest/staging/devspaces/build-requirements/devspaces-3.8-pluginregistry/ and https://download.devel.redhat.com/rcm-guest/staging/devspaces/build-requirements/devspaces-3.9-pluginregistry/ are deleted.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

nickboldt avatar Jan 08 '24 17:01 nickboldt

If approved, will likely want to cherrypick this to 3.11 branch and also add the --delete-old-versions flag to Jenkins jobs where vsix files are created/published.

nickboldt avatar Jan 08 '24 17:01 nickboldt

On the one hand this is a good idea and we should actually start doing it once we have cachito builds running. On the other we have not gotten a full build of all plugins since 3.9 so I am still using those plugins to test cachito.

SDawley avatar Jan 08 '24 19:01 SDawley

I am still using those plugins to test cachito.

That's why it's a new optional flag, rather than a default behaviour. I got your back. :D

nickboldt avatar Jan 08 '24 20:01 nickboldt