devspaces-images icon indicating copy to clipboard operation
devspaces-images copied to clipboard

chore: CRW-4642 - update to go 1.19 (since...

Open nickboldt opened this issue 2 years ago • 3 comments

What does this PR do?

chore: CRW-4642 - update to go 1.19 (since we use that to build) and then run 'go mod tidy; go mod vendor'

Change-Id: I9c2c162f10f0d4c4074fe66d68f2bae1f86e7033 Signed-off-by: Nick Boldt [email protected]

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit message above for issue number)

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

nickboldt avatar Aug 01 '23 15:08 nickboldt

is this not the change that was reverted upstream? looks very different from https://github.com/che-incubator/kubernetes-image-puller/pull/156/files

nickboldt avatar Aug 22 '23 19:08 nickboldt

That was crypto specifically, go stayed at 1.15 As a general rule if we can get it to work I am pro moving to 1.19, though maybe that should be in 3.x not 3.8

Maybe updating all of go instead of just crypto will fix the 'no utils' issue. Maybe its delusion, maybe it's hope.

I'll test it locally.

SDawley avatar Aug 22 '23 19:08 SDawley

OK not working locally. :/ But we should get back to this at some point because a number of the open CVEs I've looked at were regarding go.

SDawley avatar Aug 22 '23 21:08 SDawley