devconsole-operator icon indicating copy to clipboard operation
devconsole-operator copied to clipboard

Add controller to deploy topology service

Open akashshinde opened this issue 5 years ago • 5 comments

This PR borrows the work from https://github.com/redhat-developer/devconsole-operator/pull/195

A Deployment is created in the openshift-operators namespace such that the corresponding service would be reachable at devconsole-app.openshift-operators.svc:8080 Calls to this service would be proxied from the console backend [1] .

To Do

  • [ ] Verify that console backend is able to proxy to this
  • [x] Create Deployment
  • [x] Create Service
  • [x] Watch and reconcile
  • [ ] Parameterize the image name that is being deployed
  • [x] Add tests
    • [x] Add unit tests

akashshinde avatar May 13 '19 11:05 akashshinde

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: sbose78

If they are not already assigned, you can assign the PR to them by writing /assign @sbose78 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot avatar May 13 '19 11:05 openshift-ci-robot

@akashshinde can we please add some tests for these changes?

tinakurian avatar May 13 '19 17:05 tinakurian

A Deployment is created in the openshift-operators

@Avni-Sharma Can we deploy it in a different namespace?

sbose78 avatar May 13 '19 17:05 sbose78

@sbose78 How do you suggest to parameterize docker image path of topology service ?

akashshinde avatar May 16 '19 10:05 akashshinde

A Deployment is created in the openshift-operators

@Avni-Sharma Can we deploy it in a different namespace?

Let's create a new dedicated namespace for our service(s).

baijum avatar May 16 '19 14:05 baijum