declarative-openshift
declarative-openshift copied to clipboard
GitOps for managementCluster
This PR is for Task: https://github.com/redhat-cop/declarative-openshift/issues/48
- Create a folder to store management Cluster yaml files
- Create .bootstrap folder to store GitOps bootstrap yaml files
Please help to review . Thanks.
@senthilredhat adjust the bootstrap with helm charts.
I close this. PR , cause PR 46 already include all the commit.
re-opening - let's review this one first
@pacopeng I'm currently OOO, but will review this early next week.
Overall good work to get to this point!
Below is my feedback. We can discuss when we meet next:
- The app-of-app is an outdated approach and we should move to use ApplicationSet instead.
- With the use of an ApplicationSet, we should also consider removing the kustomize approach as the ApplicationSet can do the same (+ more), and I'd argue in a more elegant way.
- IMHO we should eliminate the manual steps (i.e.: option 2) in the README as that was mostly just a way to get us started. With the introduction of GitOps, we should just use that approach.
- An ultimate goal should be for someone to just clone this repo and use it as-is for starter (e.g.: a demo/PoC, etc.) ... it may be hard to do 100% re: OCM token, etc., but we should at least default the values that can be, i.e.: this git repo, main branch, etc.
Nitpicks:
- Please stay consistent between camelCase v.s. under_score approach
@oybed @senthilredhat
- Change app of apps to applicationSet
- Refine README
- Disable rosa cluster creation for now (it require prerequisite come from crossplane,once this PR merged we can add the integration of crossplane for prerequisites)