controller_configuration icon indicating copy to clipboard operation
controller_configuration copied to clipboard

Fix changed_when statement in all roles to show correct state and dis…

Open keilr opened this issue 1 year ago • 1 comments

What does this PR do?

In order to display diff output and correct changed state, changed_when statement needs to be set properly.

Currently changed is just inverted with the not operator, which doesn't make sense.

How should this be tested?

We tested this in our environment. Please let me know if I can help you in adding automated tests.

Is there a relevant Issue open for this?

No

Other Relevant info, PRs, etc

In order to support diff mode I also raised the following issue and pull request:

  • https://github.com/ansible/awx/pull/15118
  • https://github.com/ansible/awx/issues/14903

These are related to to underlying awx.awx (= ansible.controller) modules, used in the infra.controller_configuration roles

keilr avatar Apr 19 '24 08:04 keilr

@keilr thank you for contributing back to the community, if you could just add the changeling as Tom requested we can get this merged

djdanielsson avatar May 03 '24 13:05 djdanielsson

@Tompage1994 @djdanielsson thanks a lot for your feedback and for adding the changelog. Sorry for the delay, I was on vacation 🏖️

keilr avatar May 14 '24 09:05 keilr