controller_configuration icon indicating copy to clipboard operation
controller_configuration copied to clipboard

No consistency between `README.md`, `meta/argument_specs.yml`, and `defaults/main.yml` in filetree_read role

Open akira6592 opened this issue 1 year ago • 4 comments

Summary

There appears to be no consistency between README.md, meta/argument_specs.yml, and defaults/main.yml in filetree_read role.

README.md meta/argument_specs.yml defaults/main.yml
Required options All options are required except controller_location Only org and dir_orgs_vars are required -
Default values Default value of orgs is Acme. Default value of dir_orgs_vars is orgs_vars . orgs and dir_orgs_vars are have no default value. Because they are required #551 Default value of orgs is Acme. Default value of dir_orgs_vars is orgs_vars

Issue Type

  • Bug Report (Docs)

Ansible, Collection, Controller details

N/A (Document only)

OS / ENVIRONMENT

N/A (Document only)

Desired Behavior

N/A (Document only)

Actual Behavior

N/A (Document only)

STEPS TO REPRODUCE

N/A (Document only)

akira6592 avatar Jan 21 '24 12:01 akira6592

I think meta/argument_specs.yml is correct.

akira6592 avatar Jan 23 '24 12:01 akira6592

I believe you're right that the argument spec will be the correct one as it will be doing the checking when ran anyway.

perhaps the Iberian guys who maintain this role can comment?

CC @adonisgarciac @silvinux @ivarmu

Tompage1994 avatar Jan 26 '24 10:01 Tompage1994

Thanks a lot @akira6592 for opening this PR. I agree with you guys. I'm correcting it.

ivarmu avatar Jan 26 '24 14:01 ivarmu

Thank you for your comments.

@ivarmu

I'm correcting it.

Thank you!

akira6592 avatar Jan 27 '24 05:01 akira6592

Thank you for fixing!

akira6592 avatar Mar 25 '24 12:03 akira6592