controller_configuration icon indicating copy to clipboard operation
controller_configuration copied to clipboard

Fix Constructed Inventory colliding with defaults on controller_inventory_sources

Open Klaas- opened this issue 1 year ago • 2 comments

What does this PR do?

Follow up to #720 references #601

this changes the behaviour to allow modifications in constructed inventories, for example if you want to set a limit or modify source_vars.

I've updated the test constructed inventory to use both features.

How should this be tested?

Constructed inventory in tests/configs/inventory_sources.yml should work

Is there a relevant Issue open for this?

references #601

Other Relevant info, PRs, etc

#720

Klaas- avatar Dec 05 '23 16:12 Klaas-

Hello, Will this be merged soon? We are waiting on this fix.

mr-oz-09 avatar Feb 15 '24 14:02 mr-oz-09

I think it miss the integration test, because the inventory source definition for the constructed inventory has no organisation defined, so fall back to Default, whereas the related inventory has moved to Satellite org

adrienmrgn avatar Feb 25 '24 17:02 adrienmrgn

please update this PR to fix the conflicts and any other requested changes or I will close it soon because it has just been sitting here

djdanielsson avatar Apr 02 '24 17:04 djdanielsson

closing due to this being open for so long and no movement

djdanielsson avatar Apr 18 '24 14:04 djdanielsson