controller_configuration icon indicating copy to clipboard operation
controller_configuration copied to clipboard

Wrong default value for workflow_job_templates limit

Open bogdanmuresan opened this issue 2 years ago • 2 comments

https://github.com/redhat-cop/controller_configuration/blob/devel/roles/workflow_job_templates/tasks/main.yml#L13

Default value set for workflow templates limit is 0, but I think this should be empty string.

bogdanmuresan avatar Nov 13 '23 10:11 bogdanmuresan

it should match this as empty string, yes https://github.com/redhat-cop/controller_configuration/blob/a79f987765ae7d6ba5763c6d45c56ea7d325ec3f/roles/job_templates/tasks/main.yml#L17C145-L17C145

Funnily enough the job template api/v2/job_templates OPTIONS lists it as "", however workflow_job_template OPTIONS lists it as null.

sean-m-sullivan avatar Nov 13 '23 22:11 sean-m-sullivan

This issue should be resolved as the #729 had been merged, shouldn't it?

ivarmu avatar Dec 07 '23 11:12 ivarmu