controller_configuration icon indicating copy to clipboard operation
controller_configuration copied to clipboard

Fix typos

Open silvinux opened this issue 2 years ago • 1 comments

What does this PR do?

Fixed whitespaces between {raw} strings. Also, I've added variable "query_controller_api_max_objects" to filetree-create role README.md. Finally, I've removed from template roles/filetree_create/templates/current_organizations.j2 the galaxy_credentials variable, which was a variable used internally and it doesnt give really value. .... {%- raw %} galaxy_credentials: "{{ common_galaxy_credentials }}"

common_galaxy_credentials:

  • "Ansible Galaxy"
  • "{{ orgs }} {{ env }} Automation Hub Community Repository"
  • "{{ orgs }} {{ env }} Automation Hub Published Repository"
  • "{{ orgs }} {{ env }} Automation Hub RH Certified Repository" {% endraw %} ....

How should this be tested?

I've tested the {raw} strings examples and works OK without the whitespaces.


controller_groups:

  • name: group1 inventory: satlab-admin-inventory variables: some_var: some_val ansible_connection: local
  • name: group2 inventory: satlab-admin-inventory variables: some_var: some_val ansible_connection: local
  • name: group3 inventory: satlab-admin-inventory variables: some_var: some_val ansible_connection: local site_subnet: "{% raw %}{ % if site == 'SITE-2' %}10.200.{% else %}10.100.{% endif %}{% endraw %}" remote_subnet: "{% raw %}{ % if site == 'SITE-2' %}10.100.{% else %}10.200.{% endif %}{% endraw %}"
  • name: sat_lab_group inventory: satlab-admin-inventory variables: some_var: some_val ansible_connection: local hosts:
    • PSQL1
    • PSQL2
    • PSQL3 children:
    • group1
    • group2
    • group3 ...

#controller_hosts: [] #... controller_hosts:

  • name: PSQL1 inventory: satlab-admin-inventory variables: some_var: some_val ansible_connection: local
  • name: PSQL2 inventory: satlab-admin-inventory variables: some_var: some_val ansible_connection: local site_subnet: "{% raw %}{% if site == 'SITE-2' %}10.200.{% else %}10.100.{% endif%}{% endraw %}" remote_subnet: "{% raw %}{% if site == 'SITE-2' %}10.100.{% else %}10.200.{% endif%}{% endraw %}"
  • name: PSQL3 inventory: satlab-admin-inventory variables: some_var: some_val ansible_connection: local ...

ansible-playbook config-controller.yml --tags inventories,hosts -e "{orgs: Global, dir_orgs_vars: orgs_vars, env: demo-dev }" -e @orgs_vars/env/demo-dev/configure_connection_controller_credentials.yml --vault-password-file ./.vault_pass.txt

Cheers

silvinux avatar Sep 11 '22 13:09 silvinux

any movement on this?

sean-m-sullivan avatar Sep 22 '22 02:09 sean-m-sullivan

Could I help in anything with that PR?

ivarmu avatar Oct 26 '22 19:10 ivarmu

I think I will close this if it isn't updated by the end of the week. @silvinux

djdanielsson avatar Nov 01 '22 14:11 djdanielsson

will close this if it isn't updated by t

I'm closing this PR. I will open again once I test what sean requested

silvinux avatar Nov 03 '22 15:11 silvinux