redhat-cip
detect: Considering CPU Mhz as string representation of floats
When doing a match on a profile that have some Mhz defined, the float repesentation makes the matching code failing. As of many other values, let's consider the output as a string representation of a float. This is compatible with all the comparison operators implemented in matcher.
Signed-off-by: Erwan Velu [email protected]
We can also view this a a failure of the matching code. Maybe I have to fix the matching code more than the reporting.
We can also view this a a failure of the matching code. Maybe I have to fix the matching code more than the reporting.
That's certainly possible. In what way does it fail? Perhaps we can leave the reported value a float but make it more precise? Can you for example use math.isclose ?
That's still an open point. Is this a failure of the report or the matching code. I'd probably vote for the matching code that needs to be more clever on this.