oc-login icon indicating copy to clipboard operation
oc-login copied to clipboard

Published 20 hours ago • verified publisher icon redhat-actions

chore(deps): use node 16

Open smlgbl opened this issue 2 years ago • 1 comments

Description

Related Issue(s)

Checklist

  • [ ] This PR includes a documentation change
  • [x] This PR does not need a documentation change
  • [ ] This PR includes test changes
  • [x] This PR's changes are already tested
  • [ ] This change is not user-facing
  • [ ] This change is a patch change
  • [x] This change is a minor change
  • [ ] This change is a major (breaking) change

Changes made

smlgbl avatar Nov 01 '22 10:11 smlgbl

I'm having problems with the minify step when using together with source-map. Anybody more experienced with typescript who can help?

smlgbl avatar Nov 01 '22 13:11 smlgbl

@smlgbl can you please rebase your PR?

divyansh42 avatar Dec 23 '22 07:12 divyansh42

@smlgbl Could you please check if you have build the bundles correctly? If not, please run npm run bundle

divyansh42 avatar Dec 23 '22 09:12 divyansh42

@smlgbl Could you please check if you have build the bundles correctly? If not, please run npm run bundle

Like I wrote before, everytime I do that, it gives me the following, and it's not minified:

ncc: Compiling file index.js into CJS
ncc: Using [email protected] (local user-provided)
An error occurred while minifying. The result will not be minified.
 40kB  dist/sourcemap-register.js
268kB  dist/index.js
315kB  dist/index.js.map
315kB  dist/index.js.map
623kB  [1138ms] - ncc 0.34.0

Maybe I can give you write access, and you run it?

smlgbl avatar Dec 23 '22 10:12 smlgbl

Thanks for your PR @smlgbl

divyansh42 avatar Dec 23 '22 12:12 divyansh42

@smlgbl could you please sign your commits? Also feel free to squash the commits into one commit.

divyansh42 avatar Dec 23 '22 12:12 divyansh42

@smlgbl could you please sign your commits? Also feel free to squash the commits into one commit.

Sorry, hadn't signed anything before, hence it took a while.

smlgbl avatar Dec 23 '22 13:12 smlgbl

@smlgbl could you please sign your commits? Also feel free to squash the commits into one commit.

Sorry, hadn't signed anything before, hence it took a while.

No worries :hugs:

divyansh42 avatar Dec 23 '22 13:12 divyansh42