oc-login icon indicating copy to clipboard operation
oc-login copied to clipboard

Published 20 hours ago • verified publisher icon redhat-actions

Add post-step to do graceful logout

Open kriberg opened this issue 2 years ago • 2 comments

Description

This PR adds a post step to the action that runs oc logout and then deletes the kube config file. That should clean up any residual authentication, in case the runner will be re-used.

Related Issue(s)

Fixes #2

Checklist

  • [ ] This PR includes a documentation change
  • [x] This PR does not need a documentation change
  • [ ] This PR includes test changes
  • [ ] This PR's changes are already tested
  • [x] This change is not user-facing
  • [ ] This change is a patch change
  • [x] This change is a minor change
  • [ ] This change is a major (breaking) change

Changes made

  • Changes action description to run post step that does logout and cleanup.

kriberg avatar May 25 '22 08:05 kriberg

@kriberg Thanks for your contribution! Could you please add logout option as an input to this action and let users decide if they want to logout. Default can be set to true. Very similar to this action https://github.com/redhat-actions/podman-login/blob/main/action.yml#L20

divyansh42 avatar May 25 '22 10:05 divyansh42

@kriberg Thanks for your contribution! Could you please add logout option as an input to this action and let users decide if they want to logout. Default can be set to true. Very similar to this action https://github.com/redhat-actions/podman-login/blob/main/action.yml#L20

Will do

kriberg avatar May 25 '22 10:05 kriberg