redfin
Adding the source code to Chrome Timeline into React Server codebase
Chrome Web Store for the tool: https://chrome.google.com/webstore/detail/react-server-timeline/pockbdjjnklbgemhkhdlhbhlcfgohocc
This looks sweet!
Does it make sense to put this in packages? It doesn't seem like it's being managed as an npm package, so it could probably be another top-level folder or something.
Only reason I could think of to have it in packages/ is if we had tests for it (or if we wanted to lint it).
If it's in packages/ it needs to be private and it needs a test script that exits zero.
I vote to keep it as a package and add at least a linting target to the test script. It might not need to be an npm package, but it'd sure be easier to manage and test if we pretend like it is. Also this is super awesome and also amazing and huge thanks to @sbr1601
@gigabo @doug-wade @roblg If this is something that a dev can install with npm install react-server and use with Chrome simply by opening up some magic plugin file from the node_modules folder, then I'm all for it. If it's a plugin that needs to be installed through the Chrome App Store, then it doesn't make sense to me to include it in everyone's node_modules folder when they can't interact with it that way.
include it in everyone's node_modules folder when they can't interact with it that way
I don't follow. Which node_modules folder is it going to end up in? We build lots of projects that aren't distributed through npm in the monorepo...
@doug-wade I may not fully understand how the monorepo interacts with the rest of the world. If it doesn't get included in a normal install, then my comment is irrelevant 😁
@drewpc the monorepo design doesn't affect how users install React Server, only how developers work on it. Since none of the other modules declare a dependency on react-server-chrome-extension-timeline, it won't ever end up in their dependency closure. Once react-server-chrome-extension-timeline is marked private, it won't even end up on npm, so it'd be impossible for a react server user to get it in their node_modules.