soft particle shading not working correctly

[Jigoku]

This is under the assumption that PT_SOFT is supposed to be blending the particle texture when it intersects with overlapping geometry; for example: http://blog.wolfire.com/2010/04/Soft-Particles

The particle textures are abruptly clipped off: softparticles has no visible effect when the particlesoft shader is used, which i believe is supposed to be depth testing to factor in alpha blending similar to the wolfire link above.

[Jigoku]

So turns out it wasn't the shader, but most particles are using quadrenderer (they need softquadrenderer for it to work):

diff --git a/src/engine/renderparticles.cpp b/src/engine/renderparticles.cpp
index 5b767e87..04c58827 100644
--- a/src/engine/renderparticles.cpp
+++ b/src/engine/renderparticles.cpp
@@ -1172,7 +1172,7 @@ static partrenderer *parts[] =
     new softquadrenderer("<grey><rotate:1>particles/hint_vert", PT_PART|PT_BRIGHT),
     new quadrenderer("<grey>particles/hint_vert", PT_PART|PT_BRIGHT),
     new softquadrenderer("<grey>particles/smoke", PT_PART|PT_FLIP|PT_SHRINK|PT_WIND),
-    new quadrenderer("<grey>particles/smoke", PT_PART|PT_FLIP|PT_SHRINK|PT_WIND),
+    new softquadrenderer("<grey>particles/smoke", PT_PART|PT_FLIP|PT_SHRINK|PT_WIND),
     new softquadrenderer("<grey>particles/hint", PT_PART|PT_BRIGHT),
     new quadrenderer("<grey>particles/hint", PT_PART|PT_BRIGHT),
     new softquadrenderer("<grey>particles/hint_bold", PT_PART|PT_BRIGHT),

Wondering if this should be changed to softquad for this smoke particle?

[qreeves]

Another one that was fixed accidentally in a recent overhaul 😅