Cristian Morales Vega

There is a need for a guideline regarding C names in the std namespace?

3

There is a need for a guideline regarding C names in the std namespace? - No need to mention it, it doesn't matter if you use size_t (::size_t?) - The...

catch_discover_tests is modelled after CMake's gtest_discover_tests, but it's not up to date. Since CMake 3.18 gtest_discover_tests has supported a DISCOVERY_MODE option, which when set to PRE_TEST allows for the test...

Logging macro similar to UNSCOPED_INFO but that doesn't remove it from the buffer

1

Sometimes I have something similar to the following ``` #define CATCH_CONFIG_MAIN #include #include #include class spdlog_catch_sink final : public spdlog::sinks::base_sink { protected: void sink_it_(const spdlog::details::log_msg& msg) override { spdlog::memory_buf_t formatted;...

Request: Add ADD_SUCCESS_AT macro for third party libraries

1

As per https://github.com/rollbear/trompeloeil/pull/169#issuecomment-554357125 it would be nice to have a ADD_SUCCESS_AT to inform doctest of a successful assert in the same way ADD_FAIL_AT informs it of a failed assert.

I'm not doing it myself because I have never really edited the Wikipedia and, having just discovered GUnit, may include some wrong information (i.e. because I'm lazy). But this project...

Static extent in span

9

As far as I know there is still no proper definition of the GSL (https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#faq51-is-githubcommicrosoftgsl-the-gsl). But it seems to me that it makes sense for the definition of span to...

Feature Request: format PRIVATE/PUBLIC/INTERFACE entries with constant indentation

9

I have been formatting my PRIVATE/PUBLIC/INTERFACE commands like this ``` target_link_libraries( targetA INTERFACE targetB targetC PUBLIC targetD targetE ) ``` I would not mind if it were ``` target_link_libraries(targetA INTERFACE...

Segmentation fault / infinite loop in regular expression when handling fmt::is_formattable types

16

So this is weird, but in ``` #include #include #include #if 1 namespace trompeloeil { template struct printer { static void print(std::ostream& os, const T& t) noexcept { os

Use mutable lambda in SIDE_EFFECT?

4

I have a case were I wanted to check something sends some data, and something else receives the same data. The sender can only send by rvalue reference (I could...

Allow setting expectations in moved-from mocks

2

I have a class I want to test that is taking ownership of a mock I pass to it. This means I need to set all the expectations before passing...