baseplate.go icon indicating copy to clipboard operation
baseplate.go copied to clipboard

Uprade gobreaker version to 0.5.0

Open sagynbek opened this issue 1 year ago • 3 comments

💸 TL;DR

Update gobreaker version from 0.4.1 to 0.5.0, which adds IsSuccess to Config

📜 Details

We want to be able to customize the default behavior of IsSuccess, which defaults to check: if err is nil then it's successful, if err is non-nill then it's error Outcome: By exposing IsSuccess to user, user will be able to make more thorough check

🧪 Testing Steps / Validation

✅ Checks

  • [ ] CI tests (if present) are passing
  • [ ] Adheres to code style for repo
  • [ ] Contributor License Agreement (CLA) completed if not a Reddit employee

sagynbek avatar Jan 16 '24 17:01 sagynbek

That's good workaround, it could be useful for this case:

We get validation error, we don't want it to increase error count of Circuit breaker, but still want original err to exit function.

Counter argument might be, if it's validation error then probably resp is nil and we could use that to check? That would be right, but in general IsSuccess looks useful overall )) It's not urgent to merge, but might be included in next release? cc: @fishy

sagynbek avatar Jan 16 '24 20:01 sagynbek

Have you tested this version in production yet?

kylelemons avatar Jan 16 '24 23:01 kylelemons

Have you tested this version in production yet?

Hey @kylelemons , how can I test in production? Just bump version, and test it on staging?

sagynbek avatar Jan 17 '24 20:01 sagynbek