goose-parser icon indicating copy to clipboard operation
goose-parser copied to clipboard

Rename "type" to "dataType"

Open maZahaca opened this issue 9 years ago • 1 comments

Sometime we need to specify data type in the parsed result. For now this is a "type" field. But also we use "type" keyword as determine type of actions and transforms . So we need to rename "type" to "dataType" in cases when it has data type meaning.

maZahaca avatar Apr 20 '16 23:04 maZahaca

Would wait.js be a good example of a field that needs dataType instead of type

"wait.js" line 72:

const { type, urlPattern } = event;

While the Actions folder mostly needs type?

"actionsFactory.js" line 57-60:

addAction(type, action) {
      if (typeof type !== 'string' || typeof action !== 'function') {
          throw new Error('addAction accept type as string and action if function which must return a promise');
     }
}

I would love to help in the completion of this issue, just need to know exactly which files would be needing dataType vs regular type

danielelli avatar Dec 19 '21 02:12 danielelli