unity-mulligan-renamer icon indicating copy to clipboard operation
unity-mulligan-renamer copied to clipboard

Make Preview Results Rows reorderable

Open edwardrowe opened this issue 6 years ago • 3 comments

The results rows have a few issues that could be solved by making them reorderable:

  • Users can't reorder elements without removing them and adding them back in. Users would want to reorder elements when enumerating.
  • The delete button looks ugly on each element. A reorderable list would use the "select" and "-" pardigm that other reorderable lists use in Unity.

Bonus: Ping the object when the row is selected

edwardrowe avatar Apr 14 '18 21:04 edwardrowe

Hey @edwardrowe I made a little mistake regarding the branches and stuff and I had to delete my commit. But now everything is fine.

The preview results rows are now reorderable by clicking up/down arrows in each element. I know this its not using Unitys ReorderableList class, but I think it solves the issue, and later on we can implement it.

I also implemented the object ping when the user clicks the row.

Hope you find useful!

Mukarillo avatar Oct 13 '19 17:10 Mukarillo

I've used this a bit and decided to remove it. See #236.

If we decide to bring this back, I'd suggest we try the following;

  1. Add a subtle handle about the size of the delete button on the left of the row (maybe to the left of delete but I'm not sure). I figure it looks like two parallel lines (=), and not a button.
  2. Clicking on it would show the name next to the cursor as you drag around.
  3. Dragging it to new rows would show a thin highlight in between the two rows where it will be.
  4. When in a new position, the name next to the cursor may show the new one with an arrow. ex: "GameObject 3 => GameObject 4"

Use the behavior of Unity's reorderable lists (Layer / Tag editing) as a guide.

edwardrowe avatar Jan 29 '20 04:01 edwardrowe

BTW if you'd like to test this out, v1.7.0b1 has the buttons, v1.7.0b2 does not.

v1.7.0b1: https://github.com/redbluegames/unity-mulligan-renamer/releases/tag/v1.7.0b1 v1.7.0b2: https://github.com/redbluegames/unity-mulligan-renamer/releases/tag/v1.7.0b2

edwardrowe avatar Jan 29 '20 04:01 edwardrowe