Duo icon indicating copy to clipboard operation
Duo copied to clipboard

Fix crashes during BLE and Wifi provisioning

Open Danappelxx opened this issue 5 years ago • 3 comments

As @saamerm noted in #35 the iOS app crashes when unwrapping nil alert actions. I believe that this is due to allocating directly into a weak reference, leading to an initial reference count of zero and immediate deallocation. This PR addresses that.

Danappelxx avatar Aug 14 '18 20:08 Danappelxx

What made you wanna fix it?

saamerm avatar Aug 14 '18 20:08 saamerm

I ran into the same issue when provisioning my duo and had to resort to the serial terminal method which was a pain. After I looked at your comment I realized it was a simple fix so I went ahead and submitted it :)

Danappelxx avatar Aug 14 '18 20:08 Danappelxx

Wow, BLE provisioning has the same exact bug... can't believe this hasn't been fixed yet! I'll make another commit.

Danappelxx avatar Aug 14 '18 21:08 Danappelxx