react-native-red5pro icon indicating copy to clipboard operation
react-native-red5pro copied to clipboard

Red5 Pro SDK filepath is wrong within code(Android)

Open logandhead opened this issue 4 years ago • 3 comments

To install on android, you must manually edit a file to link the red5pro jar file. This seems to be a flaw because every time someone builds the node modules it requires you to go in every time to update the file path.

I'd suggest changing the code needing to be edited to:

dependencies {
    implementation "com.facebook.react:react-native:${safeExtGet('reactNativeVersion', '+')}"
    implementation files("../../../android/app/libs/red5streaming.jar") 
}

this will work for all react-native projects using the library because the file directory structure more than likely the same.

logandhead avatar Aug 12 '20 20:08 logandhead

Currently, the best workaround for me is to use patch-package to handle the linking during the post-install.

chungweileong94 avatar Aug 13 '20 06:08 chungweileong94

Thanks @chungweileong9! Going to still keep open because I think that there should still be a fix to the source code and we should not be required to use patch-package.

logandhead avatar Aug 13 '20 18:08 logandhead

Execution failed for JetifyTransform: E:\web1experts\Galaxy\GalaxyApp\node_modules\react-native-red5pro\android\app\libs\red5streaming.jar. > Transform's input file does not exist: E:\web1experts\Galaxy\GalaxyApp\node_modules\react-native-red5pro\android\app\libs\red5streaming.jar.

anmolsharma0002 avatar May 13 '21 05:05 anmolsharma0002