red [Regression, D2D] CRASH when BASE is big

To reproduce

Red []
view/options [base 11000x11000] [offset: 10x10]    ;) CRASHES
; view/options [base 40000x40000] []               ;) DOESNT

*** Runtime Error 98: assertion failed
*** in file: /D/devel/red/red-src/red/modules/view/backends/windows/direct2d.reds
*** at line: 1904
***
***   stack: gui/create-render-target 00000062h 004ECE48h true
***   stack: gui/create-render-target 00700D76h 02995EF0h false
***   stack: gui/get-hwnd-render-target 00700D76h false
***   stack: gui/draw-begin 0053D330h 00700D76h 00000000h false true
***   stack: gui/BaseWndProc 00700D76h 15 0 0

Expected behavior

No crash.

Platform version

Red 0.6.4 for Windows built 16-Feb-2021/11:41:34+03:00 commit #0187423

Feb 26 '21 19:02 hiiamboris

Doesn't crash for me. Interesting.

Feb 26 '21 21:02 greggirwin

Yes, curious. What if you increase the size?

Feb 26 '21 21:02 hiiamboris

Doesn't crash here. @hiiamboris Maybe no enough GPU resource was not currently available no your system. We should throw an error in this case instead of crash.

Feb 27 '21 12:02 qtxie

That's just 500MB of VRAM needed (11 * 11 * 4). I got 8GB of OS memory shared for GPU needs. And I can stably reproduce the crash.

Feb 27 '21 13:02 hiiamboris

@hiiamboris Can you check the hr value before the assertion?

Feb 28 '21 06:02 qtxie

-2147024809 or 80070057h

#define E_INVALIDARG _HRESULT_TYPEDEF_(0x80070057L).

Feb 28 '21 09:02 hiiamboris

What it was called with:

dxgi-factory: 00A258A8
d3d-device: 009B8374
hWnd: 000D0AF2
desc/Width: 16500
desc/Height: 16500
desc/Scaling: 1
desc/Flags: 0

idk where to go from here, nothing outright suspicious

Feb 28 '21 10:02 hiiamboris

If the error happened only when BASE is big, then maybe the big BASE corrupted internal memory or CreateSwapChainForHwnd cannot handle big BASE on some systems.

view/options [base 11000x11000] [offset: 10x10] works fine on my system. view/options [base 40000x40000] [] doesn't crash, but no window shows. view/options [base 40000x40000] [offset: 10x10] crashes on my system.

Mar 01 '21 03:03 qtxie

no window shows

It's an old as time layout bug. Try e.g.

view/options [] [size: system/view/screens/1/size * 1.1]
view/options [] [size: system/view/screens/1/size * 1.2]
view/options [] [size: system/view/screens/1/size * 1.5]
view/options [] [size: system/view/screens/1/size * 2]
(etc)

and see how the window slides up and to the left

Mar 01 '21 08:03 hiiamboris

view/options [base 40000x40000] [offset: 10x10] crashes on my system.

Nice, so you can debug it probably ;)

Mar 01 '21 08:03 hiiamboris

view/options [base 40000x40000] [offset: 10x10] crashes on my system.

Nice, so you can debug it probably ;)

I think it's a limitation in Direct2D. What we can do is throw an error in this case.

Mar 02 '21 07:03 qtxie

I've tested the two lines on both Win10 and Win7.

Win10 - both worked fine

Win 7:

view/options [base 11000x11000] [offset: 10x10] ;) CRASHES This went into a spinlock, taking 100% of one CPU. Had to terminate the task

view/options [base 40000x40000] [] ;) DOESNT This quickly dropped to 0% CPU. But I could not get to the window (it remained hidden behind the GUI console). And the GUI console was frozen. Again had to terminate the task,

Mar 20 '21 15:03 dsunanda

As an aside...

view/options [base 40000x40000] [offset: 10x10]

(console-2021-7-29-9050:5809): Gdk-WARNING **: 21:56:09.480: Native Windows wider or taller than 32767 pixels are not supported

Crashed Cinnamon on my Linux Mint.

Jul 30 '21 04:07 gltewalt