Refactor Symfony route names and paths to snake_case with Rector

[ahmed-bhs]

Hi Rector team,

Following the recent acceptance of the proposal to use snake_case for routes in Symfony, as detailed in this Symfony documentation pull request, I’d like to suggest adding a Rector rule that automates the refactoring of route names and paths to snake_case.

Why is this useful?

1. Consistency: Symfony is moving towards snake_case for route naming and paths, as it’s more readable and aligns with common practices in other frameworks and languages like Python and Ruby.
2. Industry standards: Major companies like Google and Facebook use snake_case in their APIs. Aligning Symfony routes with this standard will help developers transitioning from other ecosystems.
3. Automation: Having a Rector rule will make it easier to apply these changes across projects, ensuring uniformity without manual intervention.

Next Steps:

• Would this be considered useful by the Rector team?
• If so, could you guide me on how to proceed with implementing or contributing to this rule? I'd love to contribute and collaborate to make this happen.

Looking forward to your feedback and guidance!

Best regards,

[TomasVotruba]

Hi, thanks for proposal.

Sounds good to me. Feel free to send the rule :+1:

The best way to start is with the docs for custom rules: https://getrector.com/documentation/custom-rule

[ahmed-bhs]

Hi @TomasVotruba, Thank you for considering the idea. I appreciate your attention to this matter.

Here’s the plan:

1. Objective: Create a custom Rector class that renames all route names and paths to snake_case if they are currently in camelCase, kebab-case, or any other format.

2. Implementation Steps:

   • Utilize the PhpParser to access the route attribute/annotation definitions.
   • Retrieve all route attributes defined in PHP classes.
   • Use the Symfony String component to convert names and paths to snake_case.
   • Implement logic to also search for route definitions in Twig, YAML, and automatically rename them.
   • Ensure the new naming conventions are applied consistently across all identified routes.

3. Class Structure:

   • Create a class class SnakeCaseRouteRector that extends AbstractRector.
   • Implement the refactor method to iterate over the routes.
   • Define a private method to rename each route and convert it to snake_case.
   • Implement logic for handling Twig, YAML files for renaming routes.

4. Testing:

   • Thoroughly test the Rector class to ensure it correctly renames routes without breaking functionality.

5. Documentation:

   • Document the new features and usage of the custom Rector class.

If you have any comments or concerns about anything, just let me know. I’m eager to hear your thoughts on this plan!

[TomasVotruba]

Looks good. Let's start with the Rector rule :+1:

[ahmed-bhs]

Hi @TomasVotruba,

I’ve successfully implemented the rule to modify all the annotations and attributes in Symfony routes. However, I'm now focusing on how to apply these modifications to Twig templates while considering dry-run mode.

I started with the following code to update the Twig files:

private function updateTwigFiles(string $oldRouteName, string $newRouteName): void
{
    $finder = new Finder();
    $directory = 'templates'; // Adjust the path as necessary

    // Find all .twig files recursively
    $finder->files()->in($directory)->name('*.twig');

    foreach ($finder as $file) {
        $content = file_get_contents($file->getRealPath());
        $content = str_replace($oldRouteName, $newRouteName, $content);
        file_put_contents($file->getRealPath(), $content);
    }
}

The problem is that this approach modifies the files directly, which isn’t suitable for dry-run functionality.

Could you suggest a way to simulate these changes in the Twig templates without applying them immediately? Any insights or recommendations would be greatly appreciated!

Thank you!

[TomasVotruba]

Rector can only handle PHP files. We've tried changing non-PHP files before, but it only lead to problems like you describe: https://getrector.com/blog/rector-018-refocus-on-php

We can either limit the rule to handle PHP, or better create a custom tool to handle your use case.

[JoolsMcFly]

Hi.

Just a thought but couldn't dry-run just output a diff? So instead of writing changes back to the Twig file you could output them (using xdiff_string_diff I suppose) so it would result in:

templates/some/file.html.twig
- path("myRoute")
+ path("my_route")

My 2 cents.

[ahmed-bhs]

Hey @JoolsMcFly,

We could actually use sebastianbergmann/diff, which is already included in Rector. The catch is that we need to connect the rule logic with the ApplicationFileProcessor. It seems like this has already been tried, but it caused some issues, as mentioned by Tomas Votruba. So, for now, I think I’ll keep the rule focused solely on PHP classes.

[TomasVotruba]

Closing as accepted to avoid keep issue tracker focus on unclear issues that needs our attention.

Feel free to send PR with it :+1: Target: github.com/rectorphp/rector-symfony - the code quality set there

[github-actions[bot]]

This issue has been automatically locked because it has been closed for 150 days. Please open a new issue if you have a similar problem.