rector icon indicating copy to clipboard operation
rector copied to clipboard
verified publisher icon rectorphp

What happened to ReplaceAssertArraySubsetRector.php?

Open eelkeblok opened this issue 1 year ago • 3 comments

I hope somebody can shed some light on my confusion. I'm trying to use Rector for a conversion/update of a bunch of tests. I ran into the use of assertArraySubset and was happy to find https://github.com/rectorphp/rector/issues/1025. However, looking in the current codebase, I can't seem to find this. Am I looking in the wrong place, was it removed on purpose, or was it overlooked during some refactoring (as the project structure seems quite different from then)?

Thanks for any insight you might have.

eelkeblok avatar Apr 27 '24 15:04 eelkeblok

It got removed here: https://github.com/rectorphp/rector/pull/4611. Haven't found where its replacement (the polyfill) went.

eelkeblok avatar Apr 27 '24 17:04 eelkeblok

So it did make it to the separate PHPUnit package. https://github.com/rectorphp/rector/pull/5905

eelkeblok avatar Apr 28 '24 05:04 eelkeblok

Right. So there... https://github.com/rectorphp/rector-phpunit/pull/222. Not looking forward to handle all these cases manually.

eelkeblok avatar Apr 28 '24 05:04 eelkeblok