rector-downgrade-php icon indicating copy to clipboard operation
rector-downgrade-php copied to clipboard

Fix rules that were applied even if no actual change was made

Open carlos-granados opened this issue 1 year ago • 0 comments

In all three cases, the problem existed because some functions did not actually change nodes in a way that would result in a code change, they just added attributes to inner statements or expressions so that other functions could work on the code, but they still returned a node value as though it had been changed. I modified this so that these functions did not return a node. I also changed their name as they were called refactorXXX and no refactor was actually done in these functions, so I used what I think are more appropriate names

carlos-granados avatar Mar 31 '25 19:03 carlos-granados