include/cglm/io.h:70:38: error: unused parameter 'ostream' [-Werror,-Wunused-parameter]

[yurivict]

Compilation fails:

In file included from ../src/io.c:10:
In file included from ../src/../include/cglm/cglm.h:30:
../src/../include/cglm/io.h:70:38: error: unused parameter 'ostream' [-Werror,-Wunused-parameter]
glm_arch_print_name(FILE* __restrict ostream) {
                                     ^
1 error generated.

Version: 0.9.0 clang-16 FreeBSD 13.2

[recp]

Hi @yurivict

Did you compile latest sources may I ask?

[yurivict]

This is for the FreeBSD port so we only use the last release. Removing -Werror solved the problem.

[recp]

It is great to see the issue is fixed but,

I have just tried to build cglm on FreeBSD 13 ( aarch64 ), it succeeded without warnings and errors with Autotools and CMake. I did not install clang on FreeBSD yet but clang on macOS dont throw ant warnings/errors.

Maybe we should drop Werror for all build files?

[gottfriedleibniz]

I believe this issue was fixed in 0.9.1. This version hasn't been released yet, so FreeBSD Ports is still bundling 0.9.0.

For reference (this is bad, don't do it), compiling master with clang -Weverything -Wno-reserved-macro-identifier -Wno-documentation-pedantic -Wno-float-equal spits out:

cglm/include/cglm/bezier.h:124:15: warning: implicit conversion from 'int' to 'float' may lose precision [-Wimplicit-int-float-conversion]
  for (i = 0; i < CGLM_DECASTEL_MAX; i++) {

And a few other useless warnings.

[recp]

https://github.com/recp/cglm/commit/93cdc897a57275c83bfc37efab8039f30efe8075 should fix that warning thanks :)

Also this PR (https://github.com/recp/cglm/pull/328) drops Werror