incidence2 icon indicating copy to clipboard operation
incidence2 copied to clipboard

Feedback wanted: considering removing support for NSE in inputs

Open TimTaylor opened this issue 3 years ago • 1 comments

Currently we support both quoted and unquoted inputs to the incidence function making use of {rlang} and {tidyeval} to do so. Whilst on first glance this is appealing it does complicate the code base making it more complicated to maintain and increases the chance of introducing a subtle bug. I'd be inclined to remove this feature but wanted to get some feedback first. @thibautjombart - any thoughts?

TimTaylor avatar Dec 08 '21 01:12 TimTaylor

I think this is an important discussion with likely wider application to the rest of the reconverse. I would lean towards removal, but this should be a wider consultation, as we don't want to rush this and then revert the decision :) Do you have a preferred timeline for resolving this?

thibautjombart avatar Dec 08 '21 09:12 thibautjombart

Support removed by https://github.com/reconverse/incidence2/commit/1ef0420a031462eb252d69046fd6fc8f8f1b6c82

TimTaylor avatar Jan 24 '23 15:01 TimTaylor