orgalorg icon indicating copy to clipboard operation
orgalorg copied to clipboard

Support for ssh-agent and forwarding?

Open rupor-github opened this issue 9 years ago • 17 comments

Hi, are there any plans to support this?

rupor-github avatar Aug 03 '16 18:08 rupor-github

@rupor-github: Hi! Not yet. It was already mentioned in the #10. I'l glad to merge PR with ssh-agent support.

seletskiy avatar Aug 04 '16 05:08 seletskiy

Here you are: https://github.com/reconquest/orgalorg/pull/14

rupor-github avatar Aug 31 '16 23:08 rupor-github

@seletskiy did you have a chance to look at my pool requests (both runcmd and orgalorg)?

rupor-github avatar Sep 09 '16 01:09 rupor-github

@rupor-github: Sorry, I was little bit of out context lately. I will take a close look soon. Thanks for poking me.

seletskiy avatar Sep 09 '16 09:09 seletskiy

@seletskiy - Do you know if this can be merged? I am using the orgalorg tool and would like to use the ssh-agent withougt entering the passphrase everytime.

linuxbsdfreak avatar Apr 23 '18 13:04 linuxbsdfreak

Looks like the PR never got merged. What happening here?

prologic avatar Feb 08 '19 04:02 prologic

@prologic it seems that runcmd library repo was lost along with required PR, so author closed PR.

We need to restore this feature in runcmd first.

seletskiy avatar Feb 08 '19 08:02 seletskiy

This was some years ago... Is there still interest in adding this feature? I'm not seeing much evidence of activity on this project of late... Do you still actively maintain/develop it?

prologic avatar Feb 08 '19 08:02 prologic

@prologic: well, I do not use orgalorg right now, but that doesn't mean, that project is dead. If someone will add agent functionality back in runcmd then I will gladly merge PR #14.

seletskiy avatar Feb 08 '19 09:02 seletskiy

@prologic yes, I use the program on an everyday basis, the thing about it is that it just works fine.

kovetskiy avatar Feb 08 '19 10:02 kovetskiy

I undig a very old topic.

Is there any possibility to use the https://godoc.org/golang.org/x/crypto/ssh library instead of runcmd ? runcmd does not look to be maintained.

tbellembois avatar Aug 11 '19 17:08 tbellembois

@tbellembois what point do you see in it? The runcmd package doesn't do anything except wrapping golang.org/x/crypto/ssh, providing an interface which we use in orgalorg itself as abstraction layer for Local/Remote runners.

kovetskiy avatar Aug 13 '19 14:08 kovetskiy

@tbellembois nevermind, I've already forked runcmd and reworked it a bit.

Also, I've added support of ssh-agent here: https://github.com/reconquest/orgalorg/commit/ed1e994d72bbd39ea729c21bbd6cbb7294ab6c36

kovetskiy avatar Aug 13 '19 19:08 kovetskiy

flash @kovetskiy

seletskiy avatar Aug 14 '19 10:08 seletskiy

Orgalorg keeps asking for my ssh keys. Changing the main.go file into (line 707):

	if os.Getenv("SSH_AUTH_SOCK") != "" {
		sock, err := net.Dial("unix", os.Getenv("SSH_AUTH_SOCK"))
		if err != nil {
			return nil, hierr.Errorf(
				err,
				"unable to dial to ssh agent socket: %s",
				os.Getenv("SSH_AUTH_SOCK"),
			)
		}

		keyring = agent.NewClient(sock)
	} else {
		keyring = agent.NewKeyring()
	}

does the job but not sure this is the right think to do...

tbellembois avatar Sep 24 '19 18:09 tbellembois

@tbellembois feel free to open pull request!

seletskiy avatar Sep 25 '19 10:09 seletskiy

Done ! Thanks.

tbellembois avatar Sep 25 '19 12:09 tbellembois