epicontacts icon indicating copy to clipboard operation
epicontacts copied to clipboard

Address `devtools::check()` warning and note

Open jamesmbaazam opened this issue 1 year ago • 2 comments

When you run devtools::check(), you get the following warning and note that should probably be addressed:

❯ checking S3 generic/method consistency ... WARNING
  as.igraph:
    function(x, ...)
  as.igraph.epicontacts:
    function(x)
  See section ‘Generic functions and methods’ in the ‘Writing R
  Extensions’ manual.

❯ checking dependencies in R code ... NOTE
  Namespace in Imports field not imported from: ‘colorspace’
    All declared Imports should be used.
  • The first is because the as.igraph.epicontacts() is missing a ... like in its generic.

  • For the second, it appears colorspace is declared as an import but not used anywhere.

  • There is also a requirement for Encoding: UTF-8 in DESCRIPTION.

I will submit a PR to address these issues.

jamesmbaazam avatar May 12 '23 13:05 jamesmbaazam

Thanks for picking up on this! The as.igraph.epicontacts check warning should have been addressed here (ecd721e67aacec15eb36645da9f1035ef89ae6ff), so I'm not sure why you're still seeing it...

finlaycampbell avatar May 12 '23 13:05 finlaycampbell

Strange. Is it probably a devtools bug?

jamesmbaazam avatar May 12 '23 14:05 jamesmbaazam