recogito-js icon indicating copy to clipboard operation
recogito-js copied to clipboard

Changing readOnly doesn't affect relationship mode

Open rsimon opened this issue 3 years ago • 2 comments

Not covered by PR #54 yet.

rsimon avatar Nov 22 '21 11:11 rsimon

Probably won't ever address this, since relationship mode is essentially marked for deprecation now, in favour of the upcoming Connections Plugin.

rsimon avatar Dec 03 '21 11:12 rsimon

@rsimon I checked the code . If we add 'this.relationsLayer.readOnly = readOnly;' i see that it works as expected. but the documention says we should do that only from set mode.

set readOnly(readOnly) {
    this.selectionHandler.readOnly = readOnly;
    this.relationsLayer.readOnly = readOnly;
    // Note: relationsHandler.readOnly should be set by setMode.
    this.setState({ readOnly });
  }

Does it mean we should set Mode as Relations if readonly is set as false ?

apt-get2Update avatar Dec 30 '23 08:12 apt-get2Update