cloudstream icon indicating copy to clipboard operation
cloudstream copied to clipboard

[Refactor] Override domainUrl on select Extractor for changing hostname from extensions

Open Jacekun opened this issue 1 year ago • 6 comments

Ready for merge.

Some providers uses extractors but with different hostname to work.

Jacekun avatar Aug 29 '22 03:08 Jacekun

might as well make mainurl overridable then?

Blatzar avatar Aug 29 '22 11:08 Blatzar

might as well make mainurl overridable then?

hmm idk. Maybe? DomainUrl is mainly used by XstreamCdn extractor AFAIK.

Jacekun avatar Aug 29 '22 11:08 Jacekun

might as well make mainurl overridable then?

hmm idk. Maybe? DomainUrl is mainly used by XstreamCdn extractor AFAIK.

I think they do that to sidestep making new classes, tbh we need an entirely new system for that.

Blatzar avatar Aug 29 '22 11:08 Blatzar

might as well make mainurl overridable then?

hmm idk. Maybe? DomainUrl is mainly used by XstreamCdn extractor AFAIK.

I think they do that to sidestep making new classes, tbh we need an entirely new system for that.

Uh kinda. I'm the one who added domainUrl to XtreamCdn. Some extractor sites using XstreamCdn as base only works if the domain for the request is different from the mainUrl. Some uses the site url as domain for XstreamCdn

Jacekun avatar Aug 29 '22 22:08 Jacekun

Uh kinda. I'm the one who added domainUrl to XtreamCdn. Some extractor sites using XstreamCdn as base only works if the domain for the request is different from the mainUrl. Some uses the site url as domain for XstreamCdn

I dont get why every api should have it, cant you just use a superclass or interface?

LagradOst avatar Aug 31 '22 17:08 LagradOst

Uh kinda. I'm the one who added domainUrl to XtreamCdn. Some extractor sites using XstreamCdn as base only works if the domain for the request is different from the mainUrl. Some uses the site url as domain for XstreamCdn

I dont get why every api should have it, cant you just use a superclass or interface?

You're right. It can definitely be accessed thru a superclass of it. I just made it so its easier to access. If you think its not worth the code change, I'll understand.

Jacekun avatar Sep 01 '22 10:09 Jacekun