cloudstream icon indicating copy to clipboard operation
cloudstream copied to clipboard

Make settings account specific

Open Luna712 opened this issue 2 years ago • 8 comments

Describe your suggested feature

I am creating this issue because I am not sure if there is a reason not to do it intentionally. I could do a PR for this myself if it is wanted. At the very least I feel some settings should be account specific, such as "Advanced search", "Provider languages", "Preferred media", maybe other "Providers" and "Player", potentially "Layout" settings, not so much "General", "Updates and backup", or "Extensions" though. However, probably most importantly is that "Accounts" be account specific, especially those like Smikl.

Since I'm not sure on which really want to stay as shared settings, or which should be account specific I am just creating this issue. If I am told which, if any, should be account specific, I can (probably) do a PR for this myself.

Other details

No response

Acknowledgements

  • [X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • [X] I have written a short but informative title.
  • [X] I will fill out all of the requested information in this form.

Luna712 avatar Oct 03 '23 16:10 Luna712

How about installed extensions and providers are also account specific?

Rayforest avatar Oct 03 '23 16:10 Rayforest

How about installed extensions and providers are also account specific?

Installed I think shared, enabled ones could be account specific. Thats just a personal opinion though.

Luna712 avatar Oct 03 '23 16:10 Luna712

Installed I think shared, enabled ones could be account specific

Wdym by enabled ones?

For example let us say that I installed hexated repo and from this repo only sorastream was installed. Would it be better to have sora as common or account specific? Although I'm just nitpicking and I wouldn't mind either tbh

Rayforest avatar Oct 03 '23 16:10 Rayforest

Most of the settings cant be made account specific as they are implemented in a different way from setkey/getkey. that being said only the settings that makes sense should be account specific, shit like buffer size/download path/dns are all device specific so it makes no sense to wipe them when creating a new user as that will destroy the UX

LagradOst avatar Oct 03 '23 17:10 LagradOst

Most of the settings cant be made account specific as they are implemented in a different way from setkey/getkey. that being said only the settings that makes sense should be account specific, shit like buffer size/download path/dns are all device specific so it makes no sense to wipe them when creating a new user as that will destroy the UX

This I agree with. But things like Smikl should definitely be account specific in my opinion.

Luna712 avatar Oct 03 '23 17:10 Luna712

Can't we do something like:

val accountPreferences = context?.getSharedPreferences(currentAccount, Context.MODE_PRIVATE)

// Use the accountPreferences if available, or fallback to default preferences
val settingsManager = accountPreferences ?: PreferenceManager.getDefaultSharedPreferences(context)

val isAdvancedSearch = settingsManager.getBoolean("advanced_search", true)

for account specific preferences by saving some preferences files by account name?

Maybe not, just a thought if it could work?

Luna712 avatar Oct 03 '23 21:10 Luna712

@LagradOst what are your thoughts on the above? Is that something you think is feasible if I work on making some of them account specific?

Luna712 avatar Oct 07 '23 16:10 Luna712

Having at least the "Accounts" settings (Smikl/MAL/AniList) be account specific would be great. On TV I have two different startup accounts, and each of those accounts have their own MAL and AniList account - meaning to switch accounts I am currently having to select the other account in 3 different places.

Makar8000 avatar Nov 28 '23 17:11 Makar8000