Refactoring of the home page

[tuyafeng]

Describe your suggested feature

Sorry, I don't have a discord account yet, so I post it here.

I encountered some difficulties in modifying the code of the homepage, and you are also planning to modify the homepage. I think we can discuss the refactoring of the homepage.

I think the current homepage has the following problems:

• HomeFragment directly uses too many views, which makes it difficult to modify the interface
• There is not much difference between the TV interface and the mobile phone interface, but because two xml files are used, the modification of the layout code always needs to be modified twice
• kotlin-android-extensions is deprecated, its dynamic resolution slows down the compilation process (low priority)

Other details

Solution:

We can wrap some views into a view according to their functions, and add it dynamically in the code. E.g:

Before:

# layout:
<!-- We have to write twice for tv and phone, sigh -->
<LinearLayout
                android:id="@+id/home_bookmarked_holder"
                android:layout_width="match_parent"
                android:layout_height="wrap_content"
                android:orientation="vertical"
                android:visibility="gone"
                tools:visibility="visible">
<FrameLayout>
                <!-- children here, btw two many lines -->
</FrameLayout>
<androidx.recyclerview.widget.RecyclerView />
</LinearLayout>

# code:
// but we just use it once
home_bookmarked_holder.isVisible = isVisible
//...

After:

class BookmarkedContainer @JvmOverloads constructor(
    context: Context,
    attrs: AttributeSet? = null,
    defStyleAttr: Int = 0
) : FrameLayout(context, attrs, defStyleAttr) {
    // just inflate from xml or hard code here
}

class HomeFragment : Fragment() {

    private val bookmarkedContainer: BookmarkedContainer by lazy {
        BookmarkedContainer(requireContext())
    }

    override fun onCreateView(
        inflater: LayoutInflater,
        container: ViewGroup?,
        savedInstanceState: Bundle?
    ): View? {
        val layout = LinearLayout(requireContext())
        if (isTV) {
            // do somethin...
        } else {
        }
        layout.addView(bookmarkedContainer)
        return layout
    }
}

Through the above changes, we can only write the interface code once. Using it in HomeFragment to dynamically match the interface of TV and mobile phone. Also we can get rid of kotlin-android-extensions (I think it would be better to replace it with viewbinding, but that requires too many changes for now).

Acknowledgements

• [X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
• [X] I have written a short but informative title.
• [X] I will fill out all of the requested information in this form.

[Blatzar]

As long as kotlin-android-extensions doesn't impact runtime performance I'd prefer to keep it a while since view binding has been quite funky before.

Having two layout files for TV and phone is way preferable, adding views to a generic layout is extremely tedious and prone to unintentional fuckups, especially with the TV layout diverging even more in the future.

If anything should the home layout for TV also be a separate fragment but same viewmodel.

[tuyafeng]

If this is the case, maybe we should implement the TV interface and the mobile interface separately, saving the need to deal with the bad glue logic. The pseudo code is as follows:

interface HomePageView { 
  // or base class if you want to put some common logic code here
  void updateSeries(String source, bool cached);
  void updateBookmarks();
}

class HomeTabletFragment implements HomePageView {
  // do something for tv interface
}

class HomeCompactFragment implements HomePageView {
  // do something for mobile phone interface
}

[LagradOst]

I am running on the dev branch testing non nestedscrollview, it is much better