cloudstream icon indicating copy to clipboard operation
cloudstream copied to clipboard

Add search suggestions to search UI

Open NivinCNC opened this issue 1 month ago • 8 comments

Implemented search suggestions using Google's autocomplete API. Added SearchSuggestionAdapter, SearchSuggestionApi, and related UI components to display and interact with suggestions in both mobile and TV search fragments. Suggestions are fetched with debounce and can be selected to search or fill the search box.

NivinCNC avatar Dec 03 '25 16:12 NivinCNC

Resolved.

NivinCNC avatar Dec 04 '25 12:12 NivinCNC

This is virtually unusable on TV due to the focus loss. I am unsure if we only want the focus loss on phone layout or if we disable this feature on TV.

Removed focus loss for tv layout, alternatively added a clear suggestion button for tv layout to hide the suggestions and even enter or ok button also hides the suggestions in all layouts

NivinCNC avatar Dec 05 '25 10:12 NivinCNC

Removed focus loss for tv layout, alternatively added a clear suggestion button for tv layout to hide the suggestions and even enter or ok button also hides the suggestions in all layouts

same done for emulator layout

NivinCNC avatar Dec 05 '25 11:12 NivinCNC

This is virtually unusable on TV due to the focus loss. I am unsure if we only want the focus loss on phone layout or if we disable this feature on TV.

Kindly recheck with the updated layout

NivinCNC avatar Dec 09 '25 08:12 NivinCNC

@NivinCNC I think we should not use clear history btn as footer in search history, it will be kill the purpose as you need to scroll through the complete history to the end to clean history. I noticed one more thing the search history shows end of list , it is intended to show the latest search history

rockhero1234 avatar Dec 13 '25 13:12 rockhero1234

@NivinCNC I think we should not use clear history btn as footer in search history, it will be kill the purpose as you need to scroll through the complete history to the end to clean history. I noticed one more thing the search history shows end of list , it is intended to show the latest search history

Fixed "search history shows end of list , it is intended to show the latest search history". But need to know whether i have to revert clear history btn logic to the older one that has the fixed button at the bottom or is there any workaround to firelights suggection?

This has clear focus issues. It is a lot better it make the SearchSuggestionAdapter have a footer view instead. See onBindFooter and onCreateFooter.

I know that you copied search_clear_call_history and that should also be updated for the same issue.

NivinCNC avatar Dec 13 '25 16:12 NivinCNC

I think he asked to have footer on suggestion area because of focus issue on tv. You can revert clear history as was before

rockhero1234 avatar Dec 13 '25 16:12 rockhero1234

I think he asked to have footer on suggestion area because of focus issue on tv. You can revert clear history as was before

No, clear history should be like this on TV as it also has some focus issues. However on Phone it does not matter exactly where it is placed. Nevertheless, you have a great point, and it might be better for the UX to place it in a static location (on phone only). The main problem I wanted @NivinCNC solve was that of inaccessible/finicky navigation on TV.

fire-light42 avatar Dec 13 '25 17:12 fire-light42