Initialize imdb functionality for more accurate searching of movies' subtitles

[thanasistrisp]

By getting an API from https://www.themoviedb.org/ with unlimited uses and by using the https://github.com/holgerbrandl/themoviedbapi/ implementation for Java/Kotlin, now searching subs is far more accurate (for now only movies is implemented for subs, series are untouched), as the search inside app returned most ways inaccurate results. Now the search is accomplished with imdb id and year. This was already implemented, however not the imdb id as it was a TODO. For example when I was searching Dual before, the results were bad, however when searching it now we this implementation the correct subs returned!

[thanasistrisp]

Also is there a way to get the year of the selected movie to pass it through imdb finder to have even more accurate results?

[Jacekun]

Use query.year. Check if there's a UI on subtitle search for the year

[thanasistrisp]

Use query.year. Check if there's a UI on subtitle search for the year

When I choose the movie I can see the year exactly before description, however query.year always returns null (as I checked through debug)

[Blatzar]

Why cannot the tmdb api already present in app be used?

[thanasistrisp]

Well, I used the defined inapp api. However, my question remains: how can I get the year of the movie? By using query.year I get null. This need to be fixed. If anyone can implement it or guide me to implement it, as I think it was an unresolved bug, as even without using the tmdb api, year was never been considered as a parameter to subtitles search here: false -> "$host/subtitles?query=$queryText&languages=${fixedLang}$yearQuery$epQuery$seasonQuery"

[Blatzar]

Well, I used the defined inapp api. However, my question remains: how can I get the year of the movie? By using query.year I get null. This need to be fixed.

See https://github.com/recloudstream/cloudstream/blob/master/app/src/main/java/com/lagradost/cloudstream3/ui/player/GeneratorPlayer.kt#L340 The year is simply never set, this is simply because we have not bothered to pass over the data from the info page yet

[Jacekun]

The year is simply never set, this is simply because we have not bothered to pass over the data from the info page yet

And now it will be possible with PR #232

[Luna712]

@thanasistrisp @fire-light42 Is it okay if I try to do this PR again using current APIs or do you want me to leave this and it'll be completed again?

[thanasistrisp]

@thanasistrisp @fire-light42 Is it okay if I try to do this PR again using current APIs or do you want me to leave this and it'll be completed again?

You can try it of course.