comfyui-prompt-reader-node icon indicating copy to clipboard operation
comfyui-prompt-reader-node copied to clipboard

[FEATURE REQUEST] - Extractor for most additional options and new nodes

Open Azornes opened this issue 7 months ago • 4 comments

Summary

Extractor for most additional options and new nodes: Name String: Sampler Name String: VAE Int: Clip skip Boolean: Pad conds

Basic Example

I would like to thank you for your work, and I have a few suggestions for additions. Extractor for Additional Options:

  • Name String: Sampler
    • Example from the prompt reader: "Sampler: DPM++ 2M SDE Heun Karras"
    • In this case: "DPM++ 2M SDE Heun Karras"
  • Name String: VAE
    • Example from the prompt reader: "VAE: kl-f8-anime2.ckpt"
    • In this case: "kl-f8-anime2.ckpt"
  • Int: Clip skip
    • Example from the prompt reader: "Clip skip: 2"
    • In this case: "2" (If this option isn't in the prompt reader, return "1")
  • Boolean: Pad conds
    • Example from the prompt reader: "Pad conds: True"
    • In this case: "True" (If this option isn't in the prompt reader, return "False")

Of course, the names of VAEs and models can sometimes be unhelpful if they are, for example, in folders. Therefore, I would suggest creating a new node that searches the folders with the given name and, if found, automatically returns the entire path to that model, for example, "Anime/anime_v10.safetensor" and pass to Checkpoint Selector. Similarly, for the names of samplers, there should be an additional node that extracts the sampler_name from the string and pass to Sampler Selector as well as the scheduler and pass to Scheduler Selector.

If you think that dealing with names and their additional node converters would be too much work, I would mainly request the output for Clip skip and Pad conds.

Reference Issues.

No response

Azornes avatar Nov 29 '23 12:11 Azornes