recap icon indicating copy to clipboard operation
recap copied to clipboard

Detect unsigned integers in MySQL converter

Open mjperrone opened this issue 10 months ago • 2 comments

Adds support for unsigned integer values to the MySQL converter

UNSIGNED, if specified, disallows negative values. The UNSIGNED attribute is deprecated for columns of type FLOAT (and any synonyms) and you should expect support for it to be removed in a future version of MySQL. Consider using a simple CHECK constraint instead for such columns.

https://dev.mysql.com/doc/refman/8.4/en/numeric-type-syntax.html

mjperrone avatar Apr 03 '25 17:04 mjperrone

The failure in the job is caused by issues with pulling certain Docker images, specifically the ghcr.io/recap-build/hive-metastore-standalone:latest image, which encountered an "access denied" error. Additionally, other services (e.g., MySQL, Zookeeper, Kafka) failed due to "context canceled" errors, likely cascading from the failure to pull the required images.

Solution

  1. Fix Access Issue for the Hive Metastore Image:

    • Ensure that the GitHub Actions runner has proper access to the ghcr.io container registry.
    • Update the workflow to include authentication for the GitHub container registry by adding a docker login.
    • Example:
      - name: Log in to GitHub Container Registry
        run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u USERNAME --password-stdin
      
  2. Verify Image Availability:

    • Confirm that the ghcr.io/recap-build/hive-metastore-standalone:latest image exists and is published correctly in the registry.
    • If access is restricted, ensure the runner's token or credentials have permission.
  3. Update Docker Compose Version:

    • The warning about the version field being obsolete indicates compatibility issues; update the docker-compose.yml file to use a supported version.
    • Replace:
      version: '3.8'
      
      with:
      version: '3.9'
      
  4. Retry Logic for Service Pulls:

    • Add retry logic to handle transient errors in pulling images or starting services.

Updated Workflow Section

Here's how to fix the integration-tests job in .github/workflows/ci.yaml:

- name: Log in to GitHub Container Registry
  run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u USERNAME --password-stdin

- name: Docker Compose Up
  uses: isbang/[email protected]
  with:
    compose-file: tests/docker-compose.yml

Updated docker-compose.yml

Ensure the version field is updated:

version: '3.9'

By implementing these changes, the workflow should be able to authenticate with the GitHub Container Registry, successfully pull images, and resolve the cascading failures in the job.

NexusGKSoftwares avatar Apr 23 '25 21:04 NexusGKSoftwares

Ah, I think this is because I moved the package to:

https://github.com/criccomini/hive-metastore-standalone

criccomini avatar Apr 24 '25 16:04 criccomini