aws-nuke icon indicating copy to clipboard operation
aws-nuke copied to clipboard

dateOlderThan will not fatal error on datetime parse failure

Open WesselBBD opened this issue 2 years ago • 1 comments

I encountered a problem where, if the tag of a resource couldn't be parsed as a date (e.g tag: Expirationdate: "IamNotADate") the service module would fatal error wit "Error: unable to parse time IamNotADate".

This would normally be fine but sadly it errors out the entire module, so if the bad date was in a single EC2 instances the entire EC2Instance module stops and no EC2 instances gets filtered or deleted.

This fixes the problem but we might need to add a message to the user that a tag was not parsed and therefor the resource was not filtered.

WesselBBD avatar Mar 03 '22 08:03 WesselBBD

I think there should still be a warning message.

svenwltr avatar Mar 03 '22 08:03 svenwltr