Rebus icon indicating copy to clipboard operation
Rebus copied to clipboard

Any updates on 7.0 (and MySql 3.0) coming out of beta?

Open kendallb opened this issue 3 years ago • 8 comments

We still maintain our own packages, but I would prefer to flip over to your official ones but was waiting for it to come out of beta.

kendallb avatar Mar 18 '22 18:03 kendallb

No specific planned date, but if you would run with Rebus 7 pre for a while and let me know how it goes, then I would definitely consider just bumping it 🤠

If you do, you can report back here how it goes.

mookid8000 avatar Mar 21 '22 10:03 mookid8000

Been doing that for a few months already :). Not using your official builds but my own builds that are exactly the same but I can push to nuget. Happy to change to the beta ones that are current if you want? But pretty sure the code is good since we have been using it for a while.

kendallb avatar Mar 21 '22 15:03 kendallb

I am changing our code over to use the latest beta as it should be identical to our packages. Assuming no issues, can we get official builds?

kendallb avatar Mar 29 '22 19:03 kendallb

Well something is different so we had to roll it back. I will need to compare what is different in my tree and the official trees to see if maybe there is a patch we did that never made it in?

kendallb avatar Mar 30 '22 20:03 kendallb

Ok tested against latest code and it all works. Except for Autofac. That appears to have had quite a few changes since 7.x for the 8.x version and I suspect that is where the issues are coming from. So I think Rebus 7.x and Rebus.MySql 3.x are all good. But I would need to stick to Rebus.Autofac 7.x until I can sort out what is different.

kendallb avatar Apr 01 '22 20:04 kendallb

Ahh, it was changed somewhat in that you now have to resolve IBusStarter and call start on it to start the bus, if you are not automatically starting it (we do not as we either run it in one web site in development, or in a separate windows service application on multiple nodes in production). So I think easy enough to fix.

kendallb avatar Apr 01 '22 20:04 kendallb

So everything is good?

mookid8000 avatar Apr 05 '22 10:04 mookid8000

Yes we are live in production with it now.

kendallb avatar Apr 05 '22 12:04 kendallb

I see the official 7.0 is not out yet. I have not updated past 7.0.0-b5. Is there an ETA on the final release?

kendallb avatar Nov 15 '22 23:11 kendallb

Hmm, is there a reason you updated the dependencies for Newtonsoft and Json.net in RC4? This causes conflicts for me and sometimes when things get changed like that I end up in dll dependency hell trying to resolve it (still on NET Framework 4.8 at the moment and trying to migrate off).

If possible it would be nice to leave those as they were for RC2 and earlier?

kendallb avatar Nov 16 '22 01:11 kendallb

Yeah sorry about that – I've extended the allowed version ranges for both Newtonsoft.Json and System.Text.Json - could you try the latest RC (Rebus 7.0.0-rc5) and see if it works as intended?

I'll release a proper v7 as soon as you say it's good 🙂

mookid8000 avatar Nov 16 '22 10:11 mookid8000

Well it still has System.Text.Json 6.0.0 as a dependency, while up to RC2 they all used this:

Microsoft.CSharp >= 4.7.0 Newtonsoft.Json >= 11.0.1 system.text.json >= 5.0.0

We are already on Newsoft higher than that, but System.Text.Json is the one I am wondering about. Is it necessary to target 6.0 and later for that? Most of our stuff is on 5.0.2. I will try to upgrade that one and it might be OK. Somethings bringing in stuff 6.0 and above (cannot remember which one) triggers all kinds of wonky DLL hell for .NET 4.8 that is hard to sort out.

kendallb avatar Nov 16 '22 16:11 kendallb

Yeah, just moving to 6.0 of System.Text.Json in our code is causing tons of binding redirect errors I need to sort out. I can certainly do that if moving up to System.Text.Json >= 6.0.0 is necessary, but if it is not necessary I would recommend we just loosen that back to 5.0.0? That will make it a lot easier as then I don't need to deal with DLL hell and binding redirect hell until later :)

Once we move to .NET core this gets a whole lot easier as then the binding redirects can all be generated automatically, but for ASP.NET 4.8 it all goes into the Web.config file and is a pain in the but.

kendallb avatar Nov 16 '22 16:11 kendallb

I managed to get it updated. I updates System.Text.Json to 6.0.7 and then had to update Microsoft.Bcl.AsyncInterfaces to 6.0.0 also. But that seems to be in. I can test RC5 now in production but I still think it should be loosened to 5.0.0 for the GM unless there is a good reason to force the upgrade to 6.0.0?

kendallb avatar Nov 16 '22 16:11 kendallb

(..) unless there is a good reason to force the upgrade to 6.0.0?

Can't say there is 😅 I've released Rebus 7.0.0-rc6 now with the allowed version range extended to include 5

mookid8000 avatar Nov 17 '22 08:11 mookid8000

Ok great. Far as I can tell everything is good as we are running RC5 in production since yesterday.

kendallb avatar Nov 17 '22 12:11 kendallb

So far so good on the code so if you want to push it, that is fine with me. But I am seeing some really strange issues with MySQL where I think multiple threads get the same message if the timing is exactly right. So I might make a couple of minor changes and test it. But to test it, I will need to go back to my local version until you get the official code published.

Do you want me to test that and then if it's good, you can publish that? It would only be an update to the MySQL connector, so that could be a separate update later if you want. But otherwise there are zero issues for me with Rebus 7 and MySQL 3

kendallb avatar Nov 28 '22 21:11 kendallb

I have committed my change to the MySQL tree and did a PR. If you can build that and push it, I can try it out. Otherwise I will try to do my own build again and test that as I am pretty sure we are still having issues with the same message getting processed by multiple threads.

kendallb avatar Nov 29 '22 15:11 kendallb

I've released Rebus 7.0.0 to NuGet.org nowe 🙂

mookid8000 avatar Dec 21 '22 10:12 mookid8000