FF13Fix icon indicating copy to clipboard operation
FF13Fix copied to clipboard

Uncapped framerate breaks facial animations.

Open ziobroaatwit opened this issue 5 years ago • 49 comments

If playing at high framerates when the in-game limiter is disabled, facial animations on in-game cutscenes play back extremely quickly, skipping their transitions between each expression. This makes the appearance of the characters talking look very jarring. When the in-game limiter is re-enabled, this issue goes away.

ziobroaatwit avatar Jan 12 '20 07:01 ziobroaatwit

Hi,

Which game is affected by this? (FF13 or FF13-2?) Could you upload a save file near a cutscene where this is noticeable?

rebtd7 avatar Jan 12 '20 08:01 rebtd7

I can only test this in FF13 as I don't own FF13-2, however this clip shown here shows the correct speed at 60FPS using the limiter in-game, while this one at around 150FPS when the FPS is uncapped shows them sped up, they still technically sync to the audio, but something is going awry with the animation itself. The save game in question I'm using to check this is attached, which loads directly into the scene I recorded. ff13-40.zip

ziobroaatwit avatar Jan 12 '20 08:01 ziobroaatwit

Yep, they do seem to be broken =/

Thanks for the videos

Could you upload the save again? I believe you have uploaded the wrong one (just after the cutscene). I think the game shows the saves starting with 01, but the file names start with 00 so you probably meant to upload ff13-39.dat

rebtd7 avatar Jan 12 '20 09:01 rebtd7

It looks like lipsync engine is also running at ~150FPS.

Nucleoprotein avatar Jan 12 '20 09:01 Nucleoprotein

Yeah I'm going to say that was a late night flub on my part, here is the right one. ff13-39.zip

ziobroaatwit avatar Jan 12 '20 09:01 ziobroaatwit

Is it just me or the lip animations seem to be a bit broken even at 60FPS? Perhaps they only work properly on 30FPS (console FPS cap)?

60FPS 30FPS

I'll update the ini to cap the FPS to 60 by default, as fixing this probably won't be an easy task...

rebtd7 avatar Jan 12 '20 10:01 rebtd7

I agree with this one after comparing the two clips. I didn't even think to clamp down to 30 to check since I just assumed that they would work fine at both 30 and 60 since the port normally reaches 60 even with the aggressive frame limiting. I wonder if a method of engaging a cap for cutscenes alone would be an appropriate fix. I haven't discovered any other oddities with the FPS uncapped in gameplay yet.

ziobroaatwit avatar Jan 12 '20 15:01 ziobroaatwit

Yeah, capping the frame rate only during cutscenes would be a possible workaround for the issue

I think I'll want to spent some time trying to understand and fix the real issue before doing something like that though

Interestingly enough, the lip sync doesn't seem broken in this cutscene if you change the voice language to Japanese

rebtd7 avatar Jan 17 '20 01:01 rebtd7

I got to say, I absolutely adore this mod and thank you for finally doing what Square couldn't do and actually fix the games. Playing FF13 this morning the difference is night and day. It really is.

The 60fps cutscene linked above doesn't look too bad to me, Is the jankiness really that bad above 60fps? I can live with a little bit of jank for the benefit.

If limiting the game to 30fps only during cutscenes would solve it I could live with that too, just my 2 cents. A lot of modern games do that, Injustice 2 for example.

scottjco avatar Feb 02 '20 16:02 scottjco

In my opinion, for a story based game like this, the jankiness is really a problem since the game relies on so many in-engine cutscenes that utilize the lipsync. For a proper experience, the most emotional or intense moments with camera close-ups could be ruined by the very PS2 lip-flapping motions of the broken lipsync at high framerates. 60 is acceptable, but say like I was getting at 140-180FPS, the animations are totally busted.

Additionally I'll give changing the language a shot and see if it is working correctly in Japanese. I'm curious why the two would be different other than porting mistakes.

ziobroaatwit avatar Feb 04 '20 17:02 ziobroaatwit

oh yeah I just tried it at 100fps (the max framerate I can see with this monitor) and the first cutscene I saw was jarring as heck. I'll stick with 60fps then. Which is fine since battles drop down to 80fps with anti-aliasing maxed out anyway.

scottjco avatar Feb 04 '20 19:02 scottjco

Just stumbled upon this last night, seriously thank you for fixing this i've been having issues with these games ever since I bought them, I switched various GPU and CPU generations through out the years. each one more powerful but the last but the game remained a mess. Thank you. for the first time I can experience the game at a smooth 60.

MarioTainaka avatar Apr 03 '20 18:04 MarioTainaka

For some reasons after I alt tabbed out and returned to the game the facial animations were fixed at 144fps. Everything was buttery smooth.

Mic601 avatar Jun 18 '20 16:06 Mic601

For some reasons after I alt tabbed out and returned to the game the facial animations were fixed at 144fps. Everything was buttery smooth.

Did you use fullscreen when you alt-tabbed, or was it just (borderless) windowed?

Liwenhan avatar Oct 11 '20 14:10 Liwenhan

Yeah I'm curious about that too.

Noikar avatar Dec 21 '20 17:12 Noikar

Wonder if there have been any updates to this issue and if the alt-tab workaround actually works? I have tried with both Borderless windowed and Fullscreen, both don't seem to work.

des506 avatar Jul 26 '21 16:07 des506

I'm sorry guys for the late reply. I can't seem the replicate the animation fix no matter how much I alt-tab. I'm such an idiot for not recording any of the fixed facial animation back then and I will always hate myself for that. Sorry :(

Mic601 avatar Aug 07 '21 07:08 Mic601

I spent some time with this when this issue was opened but I wasn't able to even find the routine responsible for the lip sync logic. Contributions to fix this are very welcome.

rebtd7 avatar Aug 07 '21 16:08 rebtd7

Would you be willing to add an option to limit cutscenes to 60fps? I think that would be the best compromise right now. Cutscenes aren't interactive and don't have a ton of movement in this game anyways, so the difference between 60fps vs. uncapped isn't as obvious, compared to gameplay where you're controlling the camera. Thanks!

Asherek avatar Aug 11 '21 02:08 Asherek

I agree. Capping the cutscenes to 60FPS would be the best compromise. I'll work on it once I have time.

rebtd7 avatar Aug 16 '21 02:08 rebtd7

An option to cap to 30FPS for completely faithful facial animations would be appreciated as well.

McJ0n avatar Aug 22 '21 13:08 McJ0n

Was it fixed because it's not broken for me (again) and consistently now. No need to alt tab and hope it works. This time I got a recording but the only problem is that the recording is in 60fps and I'm not able to find any way to record above that framerate. The things I've done different that could be the solution are:

-I'm running on Windows 11 (doubt) -I'm using the ultrawide screen patch on forced fullscreen (most possible)

Here's the link to patch if you wanna try it yourselves. You don't need an ultrawide to actually use the patch https://community.pcgamingwiki.com/files/file/2017-final-fantasy-xiii-ultrawide-fix/

Mic601 avatar Dec 10 '21 02:12 Mic601

While im at it here's the footage with my steam fps counter showing the framerate: https://drive.google.com/file/d/1pd5xs96PlgNlbd8Yh-F47IMBT2DYMsa7/view?usp=sharing

edit: you're gonna need to download the clip to have it play in 60fps didn't know google drive didnt support 60fps

Mic601 avatar Dec 10 '21 02:12 Mic601

Was this ever implemented? No rush, just asking.

I agree. Capping the cutscenes to 60FPS would be the best compromise. I'll work on it once I have time.

ghost avatar Feb 09 '22 05:02 ghost

@rebtd7 Hope you're doing well! Any chance you were able to add in this feature? It would be absolutely amazing to be able to cap the cutscenes to 60fps and 30fps as options. Thanks!

Asherek avatar Oct 13 '22 20:10 Asherek

While im at it here's the footage with my steam fps counter showing the framerate: https://drive.google.com/file/d/1pd5xs96PlgNlbd8Yh-F47IMBT2DYMsa7/view?usp=sharing

edit: you're gonna need to download the clip to have it play in 60fps didn't know google drive didnt support 60fps

And this only happens with ultra widescreen?

PFLI2 avatar Jun 04 '23 04:06 PFLI2

I'm not using ultra wide

On Sun, Jun 4, 2023 at 12:21 AM PFLI2 @.***> wrote:

While im at it here's the footage with my steam fps counter showing the framerate: https://drive.google.com/file/d/1pd5xs96PlgNlbd8Yh-F47IMBT2DYMsa7/view?usp=sharing

edit: you're gonna need to download the clip to have it play in 60fps didn't know google drive didnt support 60fps

And this only happens with ultra widescreen?

— Reply to this email directly, view it on GitHub https://github.com/rebtd7/FF13Fix/issues/3#issuecomment-1575376770, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJIPZIHX2LTWKGKACR62EBDXJQEM7ANCNFSM4KFWIWRQ . You are receiving this because you commented.Message ID: @.***>

Noikar avatar Jun 04 '23 13:06 Noikar

Hi! I guess I owe an explanation after all this time. It seems the game has 3 types of cutscenes. Full mocap, cheap cutscenes where characters are cycling through presets of animations and (ofc) prerendered. It seems that the facial expressions arent broken in the full mocap cutscenes. I think I got confused when i opened the game with the ultrawide hack and saw how smooth the facial expressions were for the first cutscene i have seen. All the subsequent cutscenes were all mocap'd so I was hyped and thought i found the solution until I stumbled upon the cheap cutscenes where the facial expressions were broken again. Anyway i'm redownloading the game as I'm writing this down to test those "fully mocap'd" cutscene without the ultrawide fix to see whether or not the fix changed anything to them.

I'll keep y'all updated today


De : PFLI2 @.> Envoyé : 4 juin 2023 00:21 À : rebtd7/FF13Fix @.> Cc : Mic601 @.>; Comment @.> Objet : Re: [rebtd7/FF13Fix] Uncapped framerate breaks facial animations. (#3)

While im at it here's the footage with my steam fps counter showing the framerate: https://drive.google.com/file/d/1pd5xs96PlgNlbd8Yh-F47IMBT2DYMsa7/view?usp=sharing

edit: you're gonna need to download the clip to have it play in 60fps didn't know google drive didnt support 60fps

And this only happens with ultra widescreen?

— Reply to this email directly, view it on GitHubhttps://github.com/rebtd7/FF13Fix/issues/3#issuecomment-1575376770, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQABTCV3UVGTPPIJOGGSJPTXJQENBANCNFSM4KFWIWRQ. You are receiving this because you commented.Message ID: @.***>

Mic601 avatar Jun 04 '23 14:06 Mic601

@PFLI2 Ok done downloading. Applied the FFXIII fix and nothing else. Launched a save where I knew there was a "fully mocap'd" cutscene and it's working perfectly fine. So we can scratch the UW fix. My theory of the 3 types of cutscenes stands true as of now. Here's the proof: https://drive.google.com/file/d/1NHRwFKn5XJrfmKTQB4XTK9RgP4jIx-KJ/view?usp=sharing As you can see on my steam FPS counter I get an average of 130fps and the facial animations are perfectly fine. (download the video for the full resolution and framerate)

Mic601 avatar Jun 04 '23 14:06 Mic601

@Mic601 That's an excellent find. So all we need to test are these "cheaper" cutscenes. How common are they?

PFLI2 avatar Jun 05 '23 19:06 PFLI2