Dantotsu
Dantotsu copied to clipboard
rebelonion
Add the ability to stream torrents video in app itself.
As of now, the app open the torrent video in different app, make it stream torrents in the app itself.
https://github.com/rebelonion/Dantotsu/assets/70383209/5191f8eb-4608-4252-99cc-c3015a8f427b
@AbandonedCart 😅
Okk leave this now.
Can you add something like , accessing content of an extension. As of now only way to do it is through clicking wrong title.
I feel like that one sort of breaks the whole concept. If you're just looking through extensions directly, you wouldn't really need the rest of the app. Half the fun is stumbling through it.
Besides having to search in the other direction to link it back up to all the tracking and stuff.
Sub/dub toggle for gogo, animepahe and many more extension aren't implemented.
I found a library that is supposed to work with exo, so I'm doing some research
The other issue is that the current build takes about 4 minutes. Building the library adds a full 3 minutes to that. Using a prebuilt library adds 35MB to the repo. Both slow things down quite a bit.
Ig then dont add it, many people won't like the app size get increased.
Or would be better if you make a fork and put it there, so that those who want to use, can use that fork.
It's a 35mb increase lol, it's not that deep
Need to ask in discord first 😅
The whole playback process is also slow AF. About a 15 second minimum.
@AbandonedCart It's really slow, but I think it could be improved, it also doesn't detect subtitles or multi audio, I have a suggestion if you don't want it to take up so much space in the APK, why not, an option to install the player within the same dantotsu something like an addon
It's not a player, though. It's literally just a virtual server for the torrent. It's passing the updated url back to the existing video wrapper and media object. It plays directly in exo.
10 seconds through Actions.
There wasn't much value in making it part of the same project, except for building. Both actions and gradle have a way to download files, so it just downloads a compiled version from a fork of the server that has all the changes.
I'm open to adding it. Another option is making a torrent flavor and a regular flavor that just redirects to another app
I think kuukiyomi had the right idea by making it a fork of aniyomi. Making it a flavor requires a lot of needless overhead, but including it means it more or less runs whether you use it or not.
I already have a fork that includes it, so I think it might be best to leave it at that. I can focus on improving it and nobody here has to worry about the impact on the rest of the app.
If torrent support is integrated in the future, it will be crucial to implement corresponding updates to the player to enable embedded subtitle and multi-audio support. Without these necessary adjustments to the player, users would be unable to select subtitles or switch between audio options seamlessly.
but including it means it more or less runs whether you use it or not.
That could easily be a setting.
Lemme put it this way. It's something I'd probably use, and at that point I may just want it in the app. Still unsure tho
If torrent support is integrated in the future, it will be crucial to implement corresponding updates to the player to enable embedded subtitle and multi-audio support. Without these necessary adjustments to the player, users would be unable to select subtitles or switch between audio options seamlessly.
The app already has embedded subtitles
There's a lot of stuff that still has to be worked out in relation to torrents.
most definitely. This is a longer term project. Btw, have you looked apk sizes with splits? I may end up doing that anyways.
splits {
abi {
enable true
reset()
include 'armeabi', 'armeabi-v7a', 'arm64-v8a', 'x86', 'x86_64'
universalApk true
}
}
If torrent support is integrated in the future, it will be crucial to implement corresponding updates to the player to enable embedded subtitle and multi-audio support. Without these necessary adjustments to the player, users would be unable to select subtitles or switch between audio options seamlessly.
- [x] Embedded Subtitle
- [x] Use sub settings
- [x] Embedded Audio
Where can I test this new changes?
Ngl you can be difficult to work with, but I doubt he has a vendetta against you. I also don't think even he would argue that he's super skilled yet, but incompetent is a bit strong. For the hardcoded strings, even I've accidentally let some slip through. And I haven't had time to look at the contributor change, but if all he did was put the contributors before the other people, I'd prefer it that way honestly.